Repository navigation
fix: reject SQL escape strings in read-only queries - #635
Merged
Merged
Conversation
Reject PostgreSQL E/e escape-string literals at the shared read-only query boundary so protected-column inspection cannot be bypassed. Cover the reported exploit through DbAdmin and SqlKnowledgeReader, plus ordinary literals, comments and dollar quoting. Fixes #612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Reject PostgreSQL E/e escape-string literals at the shared read-only query boundary so protected-column inspection cannot be bypassed.
Cover the reported exploit through DbAdmin and SqlKnowledgeReader, plus ordinary literals, comments and dollar quoting.
Fixes #612
Testing
Api.Tests:
FullyQualifiedName~DbAdmin|FullyQualifiedName~SqlKnowledgeReaderTests— 228 passed. The exploit is exercised through both production query entry points, alongside accepted quoting/comment cases.git diff --checkpassed. Full CI runs on this PR.