Revert "让 SDK 日志时间在 UTC 容器中稳定显示东八区"#125
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the logging timestamp behavior introduced in PR #123, returning agentrun.utils.log.CustomFormatter to Python’s default logging.Formatter time conversion behavior (i.e., %(asctime)s reflects the process/local timezone rather than a forced UTC+8 offset).
Changes:
- Removed the UTC+8
converteroverride (_utc8_converter) so%(asctime)sno longer forces UTC+8. - Removed the unit tests that validated UTC+8 timestamp formatting for the SDK logger formatter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
agentrun/utils/log.py |
Reverts formatter construction to plain logging.Formatter instances (no UTC+8 converter override). |
tests/unittests/test_log.py |
Deletes the unit tests that asserted the UTC+8 logging behavior introduced in PR #123. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+51
to
55
| self._formatters[level] = logging.Formatter(fmt) | ||
| self._default = logging.Formatter( | ||
| "\n%(levelname)s [%(name)s] %(asctime)s" | ||
| " %(pathname)s:%(lineno)s\n%(message)s" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #123