fix(recording): validate Twitch auth and fall back to anonymous H.264 - #836
Draft
Serph91P wants to merge 3 commits into
Draft
fix(recording): validate Twitch auth and fall back to anonymous H.264#836Serph91P wants to merge 3 commits into
Serph91P wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Late-auth review correction
The existing completion monitor now owns authentication rejection after the startup window, without extending that window. The retry keeps the output path and proxy/direct route, fences process ownership and replaces the existing segment process rather than creating another segment or notification. The monitor releases the rotation lock before awaiting the replacement's completion.
Regression coverage exercises the real monitor task: crossing the startup deadline, existing data, unrelated errors, lost ownership, duplicate notifications and a second authentication failure from the anonymous replacement. Handoff state does not retain the resolved bearer token.
Verification
Candidate:
5b17c7bfd73f5f95762dfad789218cc2ad89da42, againstdevelopbasec679a1b577e04ccbca1c19689ab19d92f5a214d1.hermes verify --phase testrun.videos-filters-long-450 visualscreenshot failed again (65 browser tests passed, 1 failed); Integration Tests were skipped. Failure screenshots/diff/trace are now captured by the existing artifact step. The previous head's green CI is not approval for this head.Review status
Draft pending fresh independent Technical and Security review of this exact head and all required CI checks. Earlier verdicts are superseded, not waived. No frontend reference image or screenshot tolerance changed. Merge, release and deployment are not part of this PR handoff.
Fixes #834