Repository navigation
feat(settings): edit the OPC UA address in the settings window - #146
Merged
Merged
Conversation
The opc/ section had no editor, so a site moving the SCADA's OPC UA server had to edit opc/opc.yaml by hand, and the startup-failure window offered a settings dialog that could not fix an opc/ failure. The settings window gains an OPC UA block after the database block, with host and port under the existing rules: only keys that already exist, each in the file that owns it, only the keys the operator changed, validated by OpcUaConnectionLoader on a staged copy, effective at the next start. The OPC fields carry their own invalid messages, because the message line sits beside the buttons. The startup-failure window offers the dialog only when all three sections read and carry every key it edits. The absent-key message now names its section, because host and port exist in two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
opc/section added by #145 had no editor. A site moving the SCADA's OPC UA server had to editopc/opc.yamlby hand. The startup-failure window offered the settings dialog on anopc/failure, but thedialog could not edit
opc/.What changed
SettingsSavereads and saves a third section throughOpcUaConnectionLoader. The sections travel as oneordered
IReadOnlyList<SectionRead>.(1-65535).
the keys the operator changed. A staged copy is validated before any file is replaced. A change takes effect
at the next start.
SettingsOpcHostInvalidandSettingsOpcPortInvalid,because the message line sits beside the buttons.
SettingsKeyAbsentnow names the section, becausehostand
portexist in two sections.StartupFailureViewModeloffers the dialog only when all three sections read and carry every key the dialogedits.
AGENTS.md,overview.md,data-integration.md,ui-text.md,ui-theme.md(the measured messagewidths),
charting.md,readme.md.backlog.mdgets one entry: splitSettingsViewModel, now 512 lines.How it was verified
dotnet build SemiPlot.slnx: 0 errors, only the AppHost's twoNU1902.dotnet format --verify-no-changesand
dotnet terseexit 0.SemiPlot.Tests.Unit: 2529/2529.SemiPlot.Tests.Integration: 205/205.opc-missing-directoryfailure-window case failed before the gate change and passes after it.and no message is trimmed. The tightest line is the English
SettingsKeyAbsentwith the OPC UA header:445.6 of 457 px.
docs/img/settings.pngrecapture. The automated suites stand infor them in this unattended roadmap run.