Repository navigation
refactor(chart): move the marker label format to resx - #135
Merged
Merged
Conversation
The labelled marker text carried its U+00B7 separator as a \u escape in ChartMarkerLines; MarkerLineLabelFormat holds it in both sets as a glyph key.
mrcsin
force-pushed
the
marker-label-format
branch
from
October 16, 2026 14:52
7ad70c7 to
818c2f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChartMarkerLines.LabelTextOfbuilt a labelled marker's text as$"{label} · {time}": text the operator reads, with a glyph spelled as a\uescape in production code.ui-text.mdputs every operator-visible string and every non-ASCII glyph in the resx.What changed
MarkerLineLabelFormat={0} · {1}in both sets;ChartMarkerLinesreads it throughResources.FormatMarkerLineLabelFormat.ResourcesTests: the key joins the glyph keys that share their value across the two sets, andGlyphValues_KeepTheCodePointsTheOperatorSeespins itsU+00B7.ui-text.md: the key in the marker table and in the glyph list.The label the operator sees is unchanged.
Verification
SemiPlot.Tests.Unit: 2264 passed, including theChartMarkerViewTestslabel assertions.dotnet format --verify-no-changesandterseclean.