Repository navigation
fix: preserve CLI scenario overrides when using --config - #64
Open
lvliang-intel wants to merge 1 commit into
Open
lvliang-intel wants to merge 1 commit into
lvliang-intel wants to merge 1 commit into
Conversation
…onfig Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: 5cf1c724-2c15-4e70-a335-e8560d515c7a) |
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@c91eb8d4907eab3822279e972bf17eecf49bec5aRecommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@c91eb8d4907eab3822279e972bf17eecf49bec5aLast updated for commit: |
lvliang-intel
changed the title
|
Hi @FrankD412 please help review the PR. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix --scenario and --unsafe-override being ignored when used with --config.
Root Cause
The config-file merge path omitted these fields from CLI overrides, silently dropping a CLI-only scenario.
For example, our benchmark used:
aiperf profile --config benchmark_config.json --scenario inferencex-agentx-mvpThe resolved scenario remained None, so its required ignore_eos=True was never injected. Generation could stop at EOS early, despite expecting scenario-enforced EOS suppression.
Solution
Reuse _apply_scenario_fields in the config-file merge path. Explicit CLI values override file values, including False; omitted flags preserve file values. Add regression tests and document the precedence rules.
Validation
181 related tests passed, including the ignore_eos injection regression.
All applicable pre-commit checks passed.