Skip to content

CollectiveX: store results in the CollectiveX database only / CollectiveX:结果只保存在 CollectiveX 数据库中 - #4614

Merged
Oseltamivir merged 1 commit into
mainfrom
cx-results-db-only
Oct 28, 2026
Merged

Oseltamivir merged 1 commit into
mainfrom
cx-results-db-only

Conversation

@Oseltamivir

Copy link
Copy Markdown
Collaborator

Summary

CollectiveX results are stored in the CollectiveX database only. Depends on SemiAnalysisAI/InferenceX-app#1538, which adds the upload this PR documents.

  • Remove the committed MI300X and MI325X result files. Their data is already stored (the run published from CollectiveX: publish MI300X and MI325X results / CollectiveX:发布 MI300X 与 MI325X 结果 #4613), and a commit that deletes results never removes a stored run.
  • Remove .github/workflows/collectivex-results-ingest.yml, which dispatched the app's ingest for each results commit.
  • results/<sku>/ is gitignored. run.sh still writes there on the cluster, and its summary prints the directory instead of git status.
  • results/cases.json stays committed with its test (it must match the configs); the per-file result checks move to the app upload, which rejects the same things.
  • README, methodology, methodology summary and swap-blocks docs describe publishing as bun run admin:db:ingest:collectivex --dir <copy>/results from an InferenceX-app checkout.

python -m pytest collectivex/tests: 241 passed, 12 skipped.

中文

CollectiveX 结果只保存在 CollectiveX 数据库中。依赖 SemiAnalysisAI/InferenceX-app#1538,该 PR 提供本文档所述的上传功能。

  • 删除已提交的 MI300X 与 MI325X 结果文件。其数据已保存(即 CollectiveX: publish MI300X and MI325X results / CollectiveX:发布 MI300X 与 MI325X 结果 #4613 发布的运行),删除结果的提交不会移除已保存的运行。
  • 删除 .github/workflows/collectivex-results-ingest.yml,该工作流原本会为每个结果提交触发应用的 ingest。
  • results/<sku>/ 加入 gitignore。run.sh 仍在集群上写入该目录,结束时输出目录路径而不是 git status。
  • results/cases.json 及其测试保留(必须与配置一致);逐文件结果校验移至应用的上传功能,其拒绝条件相同。
  • README、methodology、methodology summary 与 swap-blocks 文档将发布方式改为在 InferenceX-app 检出目录中运行 bun run admin:db:ingest:collectivex --dir <copy>/results。

python -m pytest collectivex/tests:241 通过,12 跳过。

AI disclosure

Drafted and tested with an AI coding assistant; reviewed by the author.

Result files are no longer committed. run.sh still writes results/<sku>/<case_id>.json on the
cluster (now gitignored); publishing is an upload with InferenceX-app's
admin:db:ingest:collectivex --dir, which validates the files and stores them over the latest run.
The committed MI300X and MI325X files and the results-ingest dispatch workflow are removed; their
data is already stored. results/cases.json stays committed, and its unit test remains.

结果文件不再提交到仓库。run.sh 仍在集群上写入 results/<sku>/<case_id>.json(现已加入
gitignore);发布方式改为使用 InferenceX-app 的 admin:db:ingest:collectivex --dir 上传,
该命令会校验文件并将其叠加在最新运行之上保存。已删除提交的 MI300X 与 MI325X 文件以及
results-ingest 派发工作流,其数据已保存在数据库中。results/cases.json 仍然提交,其单元测试保留。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@Oseltamivir
Oseltamivir merged commit 324868a into main Oct 28, 2026
9 checks passed
@Oseltamivir
Oseltamivir deleted the cx-results-db-only branch October 28, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant