Repository navigation
Conversation
|
Thanks for the contribution!
中文感谢你的贡献!
|
|
Claude finished @Duyi-Wang's task in 37s —— View job LGTM - no blocking issues found |
There was a problem hiding this comment.
I reviewed this PR and found no bugs. All three changed paths have CODEOWNERS, so an AMD config owner should still take a look. One point for that person to confirm: the new decode arg enable-amd-monokernel: true is not how the other SGLang MI355X recipes in this repo turn on the mono kernel. They use monokernel-backend: amd, for example in dsv41flash/sglang/mi355x-fp4-mtp/agentic.yaml. Please confirm that the 20261028 image accepts this flag name.
What was reviewed:
- The master-config tp 4->8 change is on the
override_c1search-space row only. Rows c16, c32 and c48 already use decode TP8, so the change matches them. - In
override_c1, decodegpus: 8matchestp-size: 8, and prefill stays at TP4, the same as the master row. - The perf-changelog block was added only at the end of the file, as one block, with the existing blank-line separator kept. The image is pinned by digest in the same
tag@ sha256:form that other entries in amd-master.yaml use.
Extended reasoning...
The change bumps the image for one MI355X DSV4 SGLang disaggregated AgentX config, moves the c1 decode to TP8 with a mono-kernel flag, and adds one perf-changelog entry. It touches no security-sensitive surface. amd-master.yaml and the mi355x-* recipe tree are both covered by CODEOWNERS entries, which rules out auto-approval. I can't verify the new flag name enable-amd-monokernel from the repo, because sibling SGLang recipes use monokernel-backend: amd instead.
Update the MI355X DeepSeek-V4-Pro-0813 SGLang MoRI disaggregated AgentX image to
lmsysorg/sglang-rocm:v0.5.22-rocm10-mi35x-20261028@sha256:44202f87c180a28a6b7570f56dfb37a2c0e90dbec901b16381b87a9d582b1f27. At C1, use P-TP4 / D-TP8 and enable the AMD mono kernel on decode.Keep DSpark block size 6 (7 draft tokens), 8 request slots per role, decode graph sizes 1–8, FP8 unified KV, and UMBP offload. Other concurrency settings stay unchanged. Append the performance changelog entry.
Companion cookbook update: sgl-project/sglang#46966.
中文
将 MI355X DeepSeek-V4-Pro-0813 SGLang MoRI 分离式 AgentX image 更新为
lmsysorg/sglang-rocm:v0.5.22-rocm10-mi35x-20261028@sha256:44202f87c180a28a6b7570f56dfb37a2c0e90dbec901b16381b87a9d582b1f27。C1 使用 P-TP4 / D-TP8,并在 decode 启用 AMD mono kernel。保留 DSpark block size 6(7 draft tokens)、每侧 8 个请求槽、decode graph sizes 1–8、FP8 unified KV 和 UMBP offload。其余并发配置保持不变,并追加性能变更记录。
配套 cookbook 更新:https://github.com/sgl-project/sglang/pull/46966。
AI model disclosure
Prepared by OpenAI GPT-6 (Codex): configuration edits, documentation, and checks. The exact model/version identifier was not exposed by the runtime and could not be verified. No delegated agents were used.