Skip to content

[AMD][MI35X] 1028 DSV4 sglang mtp agentic - #4596

Open
1am9trash wants to merge 6 commits into
mainfrom
amd/dsv4-mi355x-sglang-1028
Open

1am9trash wants to merge 6 commits into
mainfrom
amd/dsv4-mi355x-sglang-1028

Conversation

@1am9trash

Copy link
Copy Markdown
Collaborator

No description provided.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. The changed paths have CODEOWNERS (the AMD config and recipe owners, plus core for the changelog), and the run still needs an accepted /use <run_id>, so a human look would still be worthwhile.

What was reviewed:

  • The image bump for dsv4-fp4-mi355x-sglang-agentic-mtp in configs/amd-master.yaml. The new rocm10 tag uses the same naming as another MI355X sglang entry already in that file.
  • The enable-amd-monokernel: true line, which is added only to override_tp8_c1 and sits alongside that override's other sglang serving flags.
  • The new perf-changelog.yaml block, which is appended at the tail with existing bytes untouched and has one entry for the affected key. Its pr-link is still the pull/XXX placeholder, as several earlier entries also are.
Extended reasoning...

This changes three YAML config lines for one benchmark key: a container image bump (rocm720 to rocm10), a new sglang monokernel flag at TP8/C1, and an appended perf-changelog entry. It touches no auth, injection or data-exposure surface. I deferred instead of approving because CODEOWNERS covers amd-master.yaml, the mi355x-* srt-slurm recipes and the changelog. The changelog entry also triggers result collection, which needs a human-accepted run before merge.

This review covers commit 6757fb8, which is no longer the latest commit on this pull request; later commits are not covered by it.

@1am9trash 1am9trash added AMD agentx AgentX benchmarks, recipes, and infrastructure non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim) labels Oct 28, 2026
@github-actions

This comment was marked as outdated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentx AgentX benchmarks, recipes, and infrastructure AMD non-canary-full-sweep-enabled Run the full sweep without the canary gate (full search space, no trim)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant