Repository navigation
CollectiveX: ask InferenceX-app to ingest results that land on main / CollectiveX:结果合入 main 时通知 InferenceX-app 导入 #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: CollectiveX Results Ingest | ||
| run-name: CollectiveX results ingest ${{ inputs.sha || github.sha }} | ||
|
|
||
| # Committed CollectiveX results on main are the dashboard's source of truth. Each push that changes | ||
| # them asks InferenceX-app to load that commit into its CollectiveX database. | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - "collectivex/results/**" | ||
| # Re-sends a commit by hand: one pushed before the app could receive it, or one whose ingest failed. | ||
| workflow_dispatch: | ||
| inputs: | ||
| sha: | ||
| description: "InferenceX commit whose collectivex/results to ingest (default: the dispatch ref)" | ||
| required: false | ||
| type: string | ||
|
|
||
| permissions: {} | ||
|
|
||
| concurrency: | ||
| group: collectivex-results-ingest-${{ inputs.sha || github.sha }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| dispatch: | ||
| name: Trigger CollectiveX ingest | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Dispatch to InferenceX-app | ||
| uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0 | ||
| env: | ||
| SHA: ${{ inputs.sha || github.sha }} | ||
| with: | ||
| github-token: ${{ secrets.FRONTEND_PAT }} # zizmor: ignore[secrets-outside-env] | ||
| script: | | ||
| if (!/^[0-9a-f]{40}$/.test(process.env.SHA)) { | ||
| core.setFailed(`not a full commit SHA: ${process.env.SHA}`); | ||
| return; | ||
| } | ||
| await github.rest.repos.createDispatchEvent({ | ||
| owner: "SemiAnalysisAI", | ||
| repo: "InferenceX-app", | ||
| event_type: "ingest-collectivex", | ||
| client_payload: { sha: process.env.SHA }, | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit (optional): The new workflow opens with a header comment explaining what it is for. AGENTS.md:56 bans these: "No header comments describing a file, topology, config, recipe, override, or section." Fix: remove lines 3-4, and put the source-of-truth rationale in the PR description or the workflow
name.Why this was flagged
In .github/workflows/collectivex-results-ingest.yml:3-4, a two-line comment between
name:andon:describes the whole workflow. AGENTS.md:54 marks the Comments section as "mandatory, every file". AGENTS.md:56 forbids header comments describing a file or config. AGENTS.md:58 allows only technical explanation of a specific line or block. The comment explains no specific line, so the PR adds a convention violation the base branch does not have. merge-ingest.yml, the sibling workflow the PR cites as its model, has no such header.Verification: Lines 3-4 of .github/workflows/collectivex-results-ingest.yml are a header comment that describes the whole workflow. AGENTS.md line 56 says "No header comments describing a file, topology, config, recipe, override, or section." The sibling .github/workflows/merge-ingest.yml has no such header. So the base branch has no violation here and this PR adds one.