Repository navigation
[Klaud Cold] Update MiniMax-M3.1-Flash FP4 GB200 SGLang AgentX DSpark image to nightly-cu134-20261026-5ef9901 / [Klaud Cold] 将 MiniMax-M3.1-Flash FP4 GB200 SGLang AgentX DSpark 镜像更新至 nightly-cu134-20261026-5ef9901 #4559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Klaud-Cold
wants to merge
4
commits into
main
Choose a base branch
from
klaud/auto-bf648dc1988312e0-65da3ed6a0f4e188
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
82bf531
chore(minimaxm31flash): bump GB200 SGLang DSpark image to nightly-cu1…
github-actions[bot] 94900b0
Merge remote-tracking branch 'origin/main' into klaud/auto-bf648dc198…
github-actions[bot] c06b832
chore(minimaxm31flash): add perf-changelog entry for GB200 SGLang DSp…
github-actions[bot] f068755
Merge remote-tracking branch 'origin/main' into klaud/auto-bf648dc198…
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit (optional): The rewritten comment above this config adds image provenance, which AGENTS.md's comment rules prohibit. Lines 5749-5750 say the image is an "upstream arm64 CUDA 13.4 nightly" carrying the support from sgl-project/sglang#45925. That is a header comment describing the config and where its image came from. Under AGENTS.md "Comments (mandatory, every file)", Git and perf-changelog.yaml are the record for this. Fix: delete those two lines and keep only the DSpark/acceptance-source lines that explain the block.
Why this was flagged
The diff rewrites the comment at inferencex-e2e/configs/nvidia-master.yaml:5749-5750 for minimaxm31flash-fp4-gb200-sglang-agentic-dspark. The new text describes where the image came from (an upstream nightly carrying sgl-project/sglang#45925). AGENTS.md:56-57 prohibits header comments that describe a config, and history comments that say what code replaced or where it came from. It names Git and perf-changelog.yaml as the record. The base comment also carried provenance (cookbook link, verification date), but this PR rewrote those lines and kept the same kind of content instead of removing it. The new perf-changelog.yaml entry already records the image change. The cost is that the comment goes stale at the next nightly bump and adds to config noise. Nothing breaks at runtime.
Verification: The diff replaces the comment at inferencex-e2e/configs/nvidia-master.yaml:5749-5750 with a header and the image's "upstream arm64 CUDA 13.4 nightly" origin. AGENTS.md:54-57 says: "No header comments describing a file, topology, config, recipe, override, or section." Git and
perf-changelog.yamlare the record. Nothing breaks at runtime.