Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions inferencex-e2e/configs/nvidia-master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5746,13 +5746,12 @@ minimaxm3-fp4-gb200-dynamo-vllm-agentic-agg-mtp:
ep: 1
dp-attn: false

# MiniMax-M3.1-Flash AgentX on GB200 with SGLang: day-zero image from the SGLang
# cookbook (https://docs.sglang.io/cookbook/autoregressive/MiniMax/MiniMax-M3.1),
# manifest digest verified 2026-10-24.
# MiniMax-M3.1-Flash AgentX on GB200 with SGLang: upstream arm64 CUDA 13.4
# nightly, which carries the MiniMax-M3.1-Flash support of sgl-project/sglang#45925.
Comment on lines +5749 to +5750

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): The rewritten comment above this config adds image provenance, which AGENTS.md's comment rules prohibit. Lines 5749-5750 say the image is an "upstream arm64 CUDA 13.4 nightly" carrying the support from sgl-project/sglang#45925. That is a header comment describing the config and where its image came from. Under AGENTS.md "Comments (mandatory, every file)", Git and perf-changelog.yaml are the record for this. Fix: delete those two lines and keep only the DSpark/acceptance-source lines that explain the block.

Why this was flagged

The diff rewrites the comment at inferencex-e2e/configs/nvidia-master.yaml:5749-5750 for minimaxm31flash-fp4-gb200-sglang-agentic-dspark. The new text describes where the image came from (an upstream nightly carrying sgl-project/sglang#45925). AGENTS.md:56-57 prohibits header comments that describe a config, and history comments that say what code replaced or where it came from. It names Git and perf-changelog.yaml as the record. The base comment also carried provenance (cookbook link, verification date), but this PR rewrote those lines and kept the same kind of content instead of removing it. The new perf-changelog.yaml entry already records the image change. The cost is that the comment goes stale at the next nightly bump and adds to config noise. Nothing breaks at runtime.

Verification: The diff replaces the comment at inferencex-e2e/configs/nvidia-master.yaml:5749-5750 with a header and the image's "upstream arm64 CUDA 13.4 nightly" origin. AGENTS.md:54-57 says: "No header comments describing a file, topology, config, recipe, override, or section." Git and perf-changelog.yaml are the record. Nothing breaks at runtime.

# Seven-token DSpark (bundled draft); synthetic acceptance follows
# infx/golden_al_distribution/minimaxm31flash_dspark.yaml.
minimaxm31flash-fp4-gb200-sglang-agentic-dspark:
image: lmsysorg/sglang:dev-minimax-m31-flash@sha256:614b1509bcb729c653528d448bff9850f8977fcad9d12ba56bd6dbe3d7985e87
image: lmsysorg/sglang:nightly-cu134-20261026-5ef9901@sha256:64460b432679d4555b6579832454d8b9a21cc8591b2d16b340b94abb59de28e6
model: MiniMaxAI/MiniMax-M3.1-Flash
model-prefix: minimaxm31flash
runner: cluster:gb200-nv
Expand Down
7 changes: 7 additions & 0 deletions inferencex-e2e/perf-changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11439,3 +11439,10 @@
- "Configure per-point batch limits, CUDA graphs, scheduler intervals, and host-cache sizes."
- "Pin the DFlash2 draft snapshot, require KV-cache metrics, and account for per-rank host-cache pools."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4446

- config-keys:
- minimaxm31flash-fp4-gb200-sglang-agentic-dspark
description:
- "Update the SGLang image from dev-minimax-m31-flash to nightly-cu134-20261026-5ef9901, pinned by digest."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4559
scenario-type: [agentic-coding]
Loading