Repository navigation
dsv4 ATOM PD AgentX on MI355X: TP4 low-concurrency points, EP8 Mega + LMCache MP at 128-512 / 低并发改 TP4,高并发改 EP8 Mega + LMCache MP #4527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5885a6d
dsv4-fp4-mi355x-atom-disagg-agentic-lmcache-dspark: TP4 low-concurren…
yhl-amd 9bf567a
perf-changelog: link PR #4527
yhl-amd 8a39ef3
dsv4 ATOM PD AgentX: EP8 Mega + LMCache MP for conc 128/256/512
yhl-amd c76dd58
Merge remote-tracking branch 'origin/main' into pr
yhl-amd f9b53be
dsv4 ATOM PD AgentX conc 128-512: bounded state replay, per-rank max-…
yhl-amd ec86d67
dsv4 ATOM PD AgentX: LMCache MP server with four workers
yhl-amd 0afa345
Merge remote-tracking branch 'origin/main' into pr
yhl-amd eb291c8
Merge remote-tracking branch 'origin/main' into pr
yhl-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The conc-16 point records a DRAM budget about half of what its LMCache tier really uses, so results understate host memory by ~750 GB. A TP4 prefill at dram-utilization 0.50 gets only 4/8 of the node share, about 749 GB (generate.py:493-507). The recipe still sizes lmcache.max_local_cpu_size: 374 per rank against the full-node 1499 GB, so it allocates ~1496 GB. Fix: make the budget and the allocation agree. Either set dram-utilization: 1.0 for this TP4 point, which gives a 1499 GB share, or cut the per-rank size to about 187 GB. Then correct the comment.
Why this was flagged
The trigger is the c16 point in amd-master.yaml under
dram-utilization: 0.50, withprefill: tp: 4andkv-offloading: dram. agentic_dram_offload_gb (infx/matrix/generate.py:493-507) computes the prefill share as available * 0.50 * 4 / 8. That is about 749 GB, written to TOTAL_CPU_DRAM_GB (infx/srt_slurm/generate.py:59). The recipe comment at disagg-lmcache-dspark.yaml:134 assumes the whole 1499 GB goes to the four prefill ranks. It sets lmcache.max_local_cpu_size: 374 per rank, so 4 x 374 = 1496 GB actually lands on host DRAM. The published result reports allocated_cpu_dram_gb (infx/results/agentic/init.py:205) at roughly half the real usage. On the base branch the TP8 prefill used 187 x 8 = 1496 GB against a 1499 GB TP8 share, so the two matched. A repo precedent (perf-changelog line 11040) shows a TP4 share of 1499 GB only at dram-utilization 1.0. No validation compares the recipe's LMCache size with total-cpu-dram-gb.Verification: Trigger: every run of the new c16 point in configs/amd-master.yaml. The new TP4 prefill gets 3000 * 0.5 * 4/8, which comes to about 749 GB. That is 4 x 374 = 1496 GB of LMCache CPU tier, about twice the 749 GB the matrix assigns and records. The only recipe-versus-matrix
TOTAL_CPU_DRAM_GBcheck is in infx/srt_slurm/single_node.py:145, and it covers single-node recipes only.