Repository navigation
config: append GB300 AgentX c5120 and c6656 points #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6c52e2d
config: append GB300 AgentX c5120 and c6656 with harness 1.0.10
cquil11 ff4aa0a
docs: link higher-concurrency points to PR 4126
cquil11 d6cd9c0
fix(ci): isolate each multi-node launcher environment
cquil11 aa51e35
chore: sync main and preserve PR 4126 sweep reuse
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The two new recipes (override_8p1d_dep2_dep16_c5120, override_10p1d_dep2_dep16_c6656) will likely get killed by SLURM before finishing, unlike the existing 8p1d point. override_8p1d_dep2_dep16_c4096 at line 207-210 sets
slurm: time_limit: "16:00:00"because the base 6h default (line 27) is too short for an 8p1d run; the new c5120 entry has the identical 4-node/8-worker prefill topology but higher concurrency (5120 vs 4096) and keeps no time_limit override, silently falling back to 6:00:00. The larger 10p1d c6656 entry has the same gap. Fix: addslurm: time_limitoverrides (>= 16:00:00, scaled for concurrency) to override_8p1d_dep2_dep16_c5120 and override_10p1d_dep2_dep16_c6656.Why this was flagged
The recipe base at disagg-variants.yaml:27 sets slurm.time_limit to "6:00:00". override_8p1d_dep2_dep16_c4096 (same file, line 207-210) overrides it to "16:00:00" because an 8-prefill-worker DEP2/DEP16 disagg run needs that long. The new override_8p1d_dep2_dep16_c5120 (line 233) has the identical prefill topology (nodes:4, workers:8) plus higher target concurrency (5120 vs 4096) but adds no slurm block, so it inherits the 6h default. override_10p1d_dep2_dep16_c6656 (line 221), an even larger 10p1d topology, has the same omission. On the base branch there is no c5120/c6656 point at all; after merge these SLURM jobs are likely to hit the 6h wall and be terminated mid-run, producing failed or truncated benchmark curve points instead of the intended data.
Verification: The new c5120 point is structurally the same run as the existing c4096 point that the author deliberately gave a 16h time limit, but it inherits the 6h base default and will be SLURM-killed before finishing.