Repository navigation
test(audit): read the NVIDIA driver fixture from the minimum table - #84
Merged
Merged
Conversation
The security policy helper hardcoded driver 580.159.03. NVIDIA bulletin 5861 raised the 580 floor to 580.178.04, so the refresh job's offline tests failed and the refresh PR was never opened. Default the driver to the table's 580-branch minimum, as runc and docker already do.
aliencaocao
requested review from
JordanNanos,
Prathmesh234 and
samharshe
as code owners
October 26, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
minimum-versions-refreshjob, which has failed daily since 2026-10-22 (e.g. run 40301365213).Cause:
security_policy()intests/audit/test_audit_common.pyhardcoded the NVIDIA driver as580.159.03. NVIDIA bulletin 5861 (2026-09-30) raised the 580 minimum to580.178.04, so after the refreshtest_security_policy_receives_only_nvidia_nic_firmwaresawnvidiaDriver: fail. The job never got to the step that opens the refresh PR.Fix:
security_policy()now takes adriverargument. By default it readscomponents.nvidiaDriver.branches["580"]from the minimum table, the same way the test already reads runc and docker.Tested:
pytest tests/audit/passes against the committed table (2120 passed) and against a locally refreshed table (2120 passed).