Repository navigation
Conversation
samharshe
marked this pull request as ready for review
October 20, 2026 22:47
samharshe
requested review from
JordanNanos,
Prathmesh234 and
functionstackx
as code owners
October 20, 2026 22:47
Bugbot is paused — your team has an unpaid invoiceBugbot is paused because your team has an unpaid invoice. Pay it from the billing page in the Cursor dashboard and Bugbot resumes automatically. (requestId: 8f8faf7f-5fd5-4acd-9d13-b2ce60def5f1) |
functionstackx
requested changes
Oct 20, 2026
functionstackx
left a comment
Contributor
There was a problem hiding this comment.
can u make it that external PRsneed approve before runnign gh actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
External-contributor PRs such as #34 pass Python tests but cannot satisfy
Analyze (actions)andAnalyze (python): the repository requires thesechecks while CodeQL default setup excludes PRs from forks.
Changes
CodeQL advancedworkflow usingpull_requestfor forks and internalbranches, pushes to
master/release/**, a weekly scan, and manual dispatch.Analyze (actions)/Analyze (python)names.pull_request_target, repository write permissions, storedcredentials, secrets, path filters, conditional skips, or fabricated checks.
docs/codeql-fork-pr-checks.md.Validation
python -m pytest -q tests/test_codeql_workflow.py: 6 passed.python -m pytest -q: 1,407 passed, 845 subtests passed.actionlint1.7.12: passed for the new workflow.git diff --check: passed.ran analysis, then failed during SARIF processing with the expected message:
CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled.the separately approved settings migration.
Migration gate
This PR does not change repository settings, required checks, or merge any PR.
GitHub rejects advanced CodeQL uploads while default setup is enabled.
The setting is still enabled. An advanced workflow failure before migration
is expected and must not be hidden with a skip or disabled upload.
After review and explicit authorization, a repository administrator must
switch CodeQL from default to advanced setup. Then rerun this PR's
CodeQL advancedjobs and verify uploaded results. Inspect the workflowidentity because default setup uses the same analysis job names.
Merge only after the new workflow and test job pass and merge is authorized.
Update #34 and other external PRs from
master, approve contributor runswhere needed, and verify both analysis checks on their current commits.
The draft status makes the remaining migration and validation gates explicit.
No repository settings were changed during preparation.
References