Skip to content

Favicon - #15

Merged
EliezerIsrael merged 1 commit into
mainfrom
claude/favicon
Oct 12, 2026
Merged

EliezerIsrael merged 1 commit into
mainfrom
claude/favicon

Conversation

@EliezerIsrael

Copy link
Copy Markdown
Member

Summary

Adds a favicon. It's a brown tile with lines of text, right-aligned like Hebrew: one word lit and the rest dimmed, echoing the engine's own highlight.

  • assets/icons/favicon.svg: the source, used by modern browsers
  • assets/icons/favicon-32.png: PNG fallback
  • assets/icons/apple-touch-icon.png: 180px and full-bleed, because iOS rounds the corners itself and would fill transparent corners with black

index.html links all three, so every sheet page gets the icon too.

Test plan

  • Checked by eye at 16, 32 and 64px on light and dark backgrounds
  • Homepage and Yitro render tests pass (they fail on any 404, so all three icons load)

🤖 Generated with Claude Code

A brown tile with lines of text, right-aligned like Hebrew: one word lit, the
rest dimmed, the engine's own highlight. SVG for modern browsers, a 32px PNG
fallback, and a full-bleed 180px apple-touch-icon (iOS rounds the corners
itself and would fill transparent ones with black).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 1/100

Base Score 4 (S=2 + A=0 + I=1 + R=1 + Q=0 + P=0) × ESF 0.1 (Nano: 3 effective lines, 1 counted file, no breadth bump) = 0.4, raised to the minimum final score of 1.

Category Score Factors
🔭 Scope 2/20 One markup file changes: index.html gains three <link> tags in <head>. Three new asset files are added under assets/icons/: favicon.svg, favicon-32.png and apple-touch-icon.png. No other HTML page is touched.
🏗️ Architecture 0/20 No module boundary or dependency changed. The page now references static files under assets/icons/.
⚙️ Implementation 1/20 favicon.svg draws a 64x64 rounded square with four <rect> bars, three dimmed with opacity=".42" and one at full opacity. index.html declares the SVG, the 32x32 PNG and the Apple touch icon with relative href values. There is no script logic.
⚠️ Risk 1/20 A wrong path or size produces a missing or blurry tab icon, and the change reverts by deleting the three <link> lines. The relative assets/icons/... hrefs would stop resolving if index.html were served from a nested path.
✅ Quality 0/15 No test accompanies the change. favicon.svg has a one-line comment describing the design. The pixel dimensions of apple-touch-icon.png cannot be checked from the diff.
🔒 Perf / Security 0/5 No performance or security work is present. The SVG is a 10-line file with no scripts or external references.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

@EliezerIsrael
EliezerIsrael merged commit 0043d96 into main Oct 12, 2026
1 check passed
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 1/100

Base Score 6 (S3 + A0 + I1 + R1 + Q1 + P0) x ESF 0.1 (Nano tier, 3 effective lines, 1 file) = 0.6, raised to the minimum of 1.

Category Score Factors
🔭 Scope 3/20 index.html gains three <link> tags in the head. Three new files are added under assets/icons/: favicon.svg, favicon-32.png and apple-touch-icon.png.
🏗️ Architecture 0/20 No module boundary or dependency changed. The head markup only references static files.
⚙️ Implementation 1/20 favicon.svg draws four rounded rectangles on a 64x64 rounded square, with three at reduced opacity and one at full opacity. The index.html links declare the SVG icon, a 32x32 PNG fallback and an apple-touch-icon.
⚠️ Risk 1/20 The change touches only the head of index.html and adds static files. A wrong path would produce a 404 on the icon request and no other effect.
✅ Quality 1/15 No test accompanies the change. favicon.svg carries one XML comment describing the design intent.
🔒 Perf / Security 0/5 No performance or security work is present.

Was this score accurate? 👍 Yes · 👎 No

How this was scored →

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant