Repository navigation
feat(noach): Parashat Noach garden from Nechama Leibowitz's gilyonot - #12
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, open calls Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h verse cache bereshit_lib keeps Bereshit's folio panels on top of the shared lib; data/bereshit.json rebuilds byte-identically. check_leaves takes an optional parsha. The provenance test accepts en_basis "nataf" (Nataf's published English of the whole item). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Five checkers read every page; one finding per checker confirmed by eye. 114 substantive differences triaged; 7 scan-only items inserted. The Noach harvest fixes three template bugs (silent drop of untriaged differences, difficulty marks written into her text, misaligned gap fragments). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…checks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Five passages x three years, 15 leaves, 58 sections, 474 steps, built by research/scripts/build_noach.py from the scan-checked harvest; every quoted card traces to it (test_provenance). - Leaves in research/scripts/noach_leaves/, paper trails in research/parshiyot/noach-leaves/. - 1970 uses Nataf's published English for her questions (en_basis nataf; the leading question number is dropped on both sides, since the digitizer's and Nataf's numbers disagree with her scan). - Phones: comparison panels get tighter padding so their text fits the 45vh panel. - test_render: measure breadcrumb headroom against the pill's max width; the pill shrinks to fit short crumbs, so the old check always reported ~8px. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… with trimmed panels Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w range wording Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lose-read-39a40e # Conflicts: # data/index.json # index.html
📊 Code Quality Score: 45/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
…ates; Perlman-box check; phone comparison limits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📊 Code Quality Score: 55/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parashat Noach: a Close Read garden from Nechama Leibowitz's gilyonot
?sheet=noachhas 5 passages, each read in 3 of her years: 15 leaves, 58 sections and 474 steps. It's built with the scan-checked Bereshit pipeline. Every quoted card is a verbatim slice of her text, checked against her original scans, andtest_provenanceproves it.The audit trail is
research/parshiyot/noach.md. §9 lists the open judgment calls for Lev.No manuscript images
I looked for Leningrad and Talmud moments. The three natural ones were accent questions in 1963, 1966 and 1967 (1967's Minchat Shai literally appeals to "accurate manuscripts" for וימח, which folio 4v shows). On the scans, all three sit in the editor's box, «שאלות בטעמי המקרא — העורך: מיכאל פרלמן». They are not hers, the same finding as Bereshit 1964 §ד. Her own Noach questions never rest on page layout, so none are used (decided 2026-10-12).
What the scan check found
All of these are settled with evidence in
noach-scancheck/triage.jsonandoverrides.json. One finding per checker, and every inserted line, was read on the scan by eye. No sheet studies Noah's drunkenness (9:20–27), confirmed across all 30 scans.Changes outside the Noach data (affect other sheets)
css/close-read.css, phones only: comparison panels get tighter padding. A comparison panel spent about 210px of the 315px phone panel on padding and labels, so her השווה tables couldn't fit even Hebrew-only at the 14px floor. All other sheets' phone tests still pass.tests/test_render.py: the breadcrumb-headroom check now measures against the pill's max width. The pill shrinks to fit short crumbs, so the old check reported about 8px for any short title, which made it impossible to pass by shortening. This fixes a measurement bug; the test isn't any looser.tests/test_provenance.py: acceptsen_basis: "nataf"(R. Francis Nataf's published English of her own words, 1970). The leading question number is dropped on both sides, because the digitizer's numbers and Nataf's disagree with her scan.research/scripts:bereshit_lib.pyis split into a sharednechama_lib.pyplus per-parshabereshit_lib/noach_lib.data/bereshit.jsonrebuilds byte-identically.check_leaves.pytakes an optional parsha.harvest_noach.pyfixes three bugs thatharvest_bereshit.pystill has (pack §8). They were harmless for Bereshit because every difference there was triaged.Tests
python3 -m pytest: 171 passed, 2 xfailed. Every Noach path passes at 1440×900 and 390×844, along with the branch clicks. The phone comparison panels keep at least 64px of headroom at the font floor, as a margin for Linux CI fonts.🤖 Generated with Claude Code