Skip to content

Add sanity check for implications #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptRaccoon merged 2 commits into from
Jul 14, 2026
Merged

Add sanity check for implications #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf1737
treat better-sqlite3 and katex as real dependencies
ScriptRaccoon Jul 14, 2026
d837ade
verify in seed script that every implication has some assumption and …
ScriptRaccoon Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion database/scripts/seed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function clear_all_tables() {
try {
tx()
} catch (err) {
console.error(`Error clearing data:`, err)
console.error(`❌ Error clearing data:`, err)
process.exit(1)
}
}
Expand Down Expand Up @@ -452,6 +452,16 @@ function seed_implications({ type, folder }: { type: StructureType; folder: stri

function insert_implications(implications: ImplicationYaml[]) {
for (const impl of implications) {
if (!impl.assumptions.length) {
console.error(`❌ Implication ${impl.id} has no assumptions.`)
process.exit(1)
}

if (!impl.conclusions.length) {
console.error(`❌ Implication ${impl.id} has no conclusions.`)
process.exit(1)
}

implication_insert.run(impl.id, type, impl.proof, Number(impl.is_equivalence))

for (const assumption of impl.assumptions) {
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,10 @@
"@types/katex": "^0.16.8",
"@types/markdown-it": "^14.1.2",
"@types/node": "^25.5.0",
"better-sqlite3": "^12.9.0",
"chokidar": "^5.0.0",
"dotenv": "^17.3.1",
"gray-matter": "^4.0.3",
"husky": "^9.1.7",
"katex": "^0.16.44",
"markdown-it": "^14.1.1",
"prettier": "^3.8.1",
"prettier-plugin-svelte": "^3.5.2",
Expand All @@ -59,6 +57,8 @@
"dependencies": {
"@fortawesome/free-regular-svg-icons": "^7.2.0",
"@fortawesome/free-solid-svg-icons": "^7.2.0",
"better-sqlite3": "^12.11.1",
"katex": "^0.17.0",
"svelte-fa": "^4.0.4",
"yaml": "^2.8.4"
}
Expand Down
50 changes: 25 additions & 25 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.