Skip to content

f3d: add shell extension registration instructions in notes field#17715

Open
B67687 wants to merge 8 commits into
ScoopInstaller:masterfrom
B67687:fix/f3d-shell-extension
Open

f3d: add shell extension registration instructions in notes field#17715
B67687 wants to merge 8 commits into
ScoopInstaller:masterfrom
B67687:fix/f3d-shell-extension

Conversation

@B67687
Copy link
Copy Markdown
Contributor

@B67687 B67687 commented Apr 30, 2026

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Closes #17335

Summary

Adds shell extension registration instructions to the f3d manifest using the notes field for manual registration.

This follows the established pattern from:

Changes

  • notes: Added instructions for users who want the Windows Explorer shell extension (thumbnail generation). Those who don't need it can install without admin rights.
  • autoupdate: Removed hash extraction (no .md5 file in f3d releases)
  • Fixed field order per contribution guidelines

The notes field provides registration instructions using elevated regsvr32 commands, allowing users to manually register the shell extension if needed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

📝 Walkthrough

Walkthrough

The bucket/f3d.json manifest file is updated to include a new notes field containing instructions for enabling Windows Explorer thumbnails through elevated PowerShell with regsvr32 commands to register and unregister F3DShellExtension.dll. The manifest also removes the MD5 hash URL template ($url.md5) from the 64-bit autoupdate configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding shell extension registration instructions to the f3d manifest via the notes field.
Linked Issues check ✅ Passed The PR successfully addresses issue #17335 by adding notes with shell extension registration instructions using regsvr32 commands, matching the issue's requested solution.
Out of Scope Changes check ✅ Passed The PR includes an additional change (removing hash extraction from autoupdate) that is a necessary technical fix unrelated to the primary objective, but this is justified and appropriate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description includes all required elements: conventional title format, contribution guide acknowledgment, issue closure reference, and detailed summary of changes with context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented Apr 30, 2026

Context on previous duplicate PR:

All tests were passing before the close. This new PR contains the same changes.

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

f3d

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/f3d.json (1)

39-44: Optional pre-merge manifest validation commands

Before merge, run the standard Scoop checks for this manifest:

.\bin\checkver.ps1 -App f3d -f
.\bin\formatjson.ps1 -App f3d
scoop install .\bucket\f3d.json -a 64bit

Reference: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/f3d.json` around lines 39 - 44, The manifest's autoupdate block
(architecture -> 64bit -> url/extract_dir) should be validated before merging:
run the Scoop validation/format and install checks by executing the checkver,
formatjson, and a test install for 64bit (as described in the contrib guide) to
ensure the URL/extract_dir templating is correct and the manifest parses and
installs cleanly; fix any issues reported by .\bin\checkver.ps1 -App f3d -f,
.\bin\formatjson.ps1 -App f3d, and scoop install .\bucket\f3d.json -a 64bit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/f3d.json`:
- Around line 39-44: The manifest's autoupdate block (architecture -> 64bit ->
url/extract_dir) should be validated before merging: run the Scoop
validation/format and install checks by executing the checkver, formatjson, and
a test install for 64bit (as described in the contrib guide) to ensure the
URL/extract_dir templating is correct and the manifest parses and installs
cleanly; fix any issues reported by .\bin\checkver.ps1 -App f3d -f,
.\bin\formatjson.ps1 -App f3d, and scoop install .\bucket\f3d.json -a 64bit.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d72cd6ab-28d0-4900-bee0-f76e64423523

📥 Commits

Reviewing files that changed from the base of the PR and between b5f4f1f and a094130.

📒 Files selected for processing (1)
  • bucket/f3d.json

@B67687
Copy link
Copy Markdown
Contributor Author

B67687 commented May 5, 2026

Validated this before merge: ran ./bin/checkver.ps1 -App f3d -f and ./bin/formatjson.ps1 -App f3d, both clean with no resulting diff. I also verified the release archive layout non-invasively: the zip root matches F3D-$version-Windows-x86_64-raytracing and contains bin\\f3d.exe and bin\\F3DShellExtension.dll, so the autoupdate URL/extract_dir templating is consistent. I did not run a live scoop install .\\bucket\\f3d.json -a 64bit against my local machine because that would mutate the local Scoop install, and the manifest already passes GitHub CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: f3d shell integration not implemented yet

1 participant