f3d: add shell extension registration instructions in notes field#17715
f3d: add shell extension registration instructions in notes field#17715B67687 wants to merge 8 commits into
Conversation
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Context on previous duplicate PR:
All tests were passing before the close. This new PR contains the same changes. |
|
All changes look good. Wait for review from human collaborators. f3d
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/f3d.json (1)
39-44: Optional pre-merge manifest validation commandsBefore merge, run the standard Scoop checks for this manifest:
.\bin\checkver.ps1 -App f3d -f .\bin\formatjson.ps1 -App f3d scoop install .\bucket\f3d.json -a 64bitReference: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/f3d.json` around lines 39 - 44, The manifest's autoupdate block (architecture -> 64bit -> url/extract_dir) should be validated before merging: run the Scoop validation/format and install checks by executing the checkver, formatjson, and a test install for 64bit (as described in the contrib guide) to ensure the URL/extract_dir templating is correct and the manifest parses and installs cleanly; fix any issues reported by .\bin\checkver.ps1 -App f3d -f, .\bin\formatjson.ps1 -App f3d, and scoop install .\bucket\f3d.json -a 64bit.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/f3d.json`:
- Around line 39-44: The manifest's autoupdate block (architecture -> 64bit ->
url/extract_dir) should be validated before merging: run the Scoop
validation/format and install checks by executing the checkver, formatjson, and
a test install for 64bit (as described in the contrib guide) to ensure the
URL/extract_dir templating is correct and the manifest parses and installs
cleanly; fix any issues reported by .\bin\checkver.ps1 -App f3d -f,
.\bin\formatjson.ps1 -App f3d, and scoop install .\bucket\f3d.json -a 64bit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d72cd6ab-28d0-4900-bee0-f76e64423523
📒 Files selected for processing (1)
bucket/f3d.json
|
Validated this before merge: ran |
<manifest-name[@version]|chore>: <general summary of the pull request>Closes #17335
Summary
Adds shell extension registration instructions to the
f3dmanifest using thenotesfield for manual registration.This follows the established pattern from:
notesfor manual registrationChanges
notes: Added instructions for users who want the Windows Explorer shell extension (thumbnail generation). Those who don't need it can install without admin rights.autoupdate: Removed hash extraction (no.md5file in f3d releases)The
notesfield provides registration instructions using elevatedregsvr32commands, allowing users to manually register the shell extension if needed.