Skip to content

Compatibility with python-xxhash v4.0 - #7262

Merged
pp-mo merged 3 commits into
SciTools:v3.16.xfrom
trexfeathers:xxhash_v4
Sep 1, 2026
Merged

Compatibility with python-xxhash v4.0#7262
pp-mo merged 3 commits into
SciTools:v3.16.xfrom
trexfeathers:xxhash_v4

Conversation

@trexfeathers

@trexfeathers trexfeathers commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #7251. This will not show up in our CI (conda-based) until conda-forge/python-xxhash-feedstock#46 is merged. But I have tested locally.

Targeting v3.16.x since this is planned to be issued as part of a patch release.

Checklist

Important

The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊


Tip

Things you can trigger on this PR:

  • Add this label to trigger benchmarks: benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
  • Visit this URL - swapping 9999 for this PR's number - to re-trigger the CLA check:
    https://cla-assistant.io/check/SciTools/iris?pullRequest=9999

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (f427270) to head (6ba18f4).

Additional details and impacted files
@@           Coverage Diff            @@
##           v3.16.x    #7262   +/-   ##
========================================
  Coverage    90.42%   90.42%           
========================================
  Files           93       93           
  Lines        25812    25814    +2     
  Branches      4795     4796    +1     
========================================
+ Hits         23340    23342    +2     
  Misses        1693     1693           
  Partials       779      779           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pp-mo pp-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was going to say we should definitely use a utf8 encoding,
but I now see that is the default anyway.

Comment thread docs/src/whatsnew/3.16/3.16.rst Outdated
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
@pp-mo
pp-mo merged commit 595af91 into SciTools:v3.16.x Sep 1, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants