Repository navigation
Bump SciMLBase compat to v3 and bump version - #93
ChrisRackauckas wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Independent review (Devin CLI 3000.11.3, model fusion-claude-opus-5-5-high-sidekick-swe-2-medium): REJECT, risk low. Full reviewVERDICT: REJECT Blocking findings
Non-blocking findings
What I ran
What I did not verify
🤖 Posted by an AI agent — harness: Devin CLI 3000.11.3 (review), Claude Code 2.1.285 (posting) · model: fusion-claude-opus-5-5-high-sidekick-swe-2-medium |
Resolve conflicts in Project.toml and test/Project.toml by taking main's side: main already carries version 1.6.4 and SciMLBase = "3.36" (SciMLBase v3 support landed via #92 and later releases, and the 2.x majors were dropped on purpose), which fully supersedes this PR's compat bump. The merged tree is identical to main. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.11.92 Agent-Model: swe-2-max Agent-Session: local Devin CLI session
What was wrong
What I changed
Validation (all run on Julia 1.12.7,
|
| Command | Result |
|---|---|
git diff origin/main...HEAD |
empty (0 lines) |
PPS_TEST_GROUP=Core timeout 3600 julia +1.12 --project=. -e 'using Pkg; Pkg.test()' |
PASS, exit 0 — Regression 49/49, Reinit 0 tests, SimpleLBFGS polish 25/25, Algorithm interface 3/3, CPU backend (gpu.jl + constraints.jl) 50/50 |
PPS_TEST_GROUP=QA timeout 3600 julia +1.12 --project=. -e 'using Pkg; Pkg.test()' |
PASS, exit 0 — QA 48/48 (Aqua/JET/ExplicitImports via SciMLTesting) |
julia +1.12 --project=@runic -m Runic --check src test |
clean, exit 0 (no Julia files differ from main, which passes format-check) |
typos (repo, over the diff scope) |
clean, exit 0 |
Pre-existing failures left alone
CUDA Tests (Julia 1)(GPU Tests workflow, self-hosted V100 runners): the PR-time failure log is expired; GPU Tests onmainare green as ofa73c0a0. Not runnable in this environment (no free GPU), and moot since the branch's tree is now identical tomain's green head.- No test changes were made; nothing was skipped, silenced, or loosened.
🤖 Posted by an AI agent — harness: Devin CLI 3000.11.92 · model: swe-2-max
Conversation: local Devin CLI session 9c68557988420b22a2ac5d527374ed01
Closing: this PR changes no files. The SciMLBase v3 compat bump it carried is already on the default branch (the redundant-PR check found an empty diff against it). Reopen if a change is still missing. 🤖 Posted by an AI agent — harness: Claude Code 2.1.309 · model: claude-sonnet-5-5 |
Summary
Supersedes #92
🤖 Generated with Claude Code