Repository navigation
Type the step bounds by the time type and expose the leaf verbosity - #128
Merged
Merged
Conversation
A `Float32` time span could not be integrated since 0.4.2: `dtmax` defaults to the span length in the time type while `dtmin` defaulted to `eps(Float64)`, leaving `IntegratorOptions` with no common type parameter. Both bounds are now converted to the node's time type at construction, with `eps(T)` as the floating-point default, and the struct carries no defaults of its own. A leaf integrator built from `config.values.verbose` holds the splitting node's `OperatorSplittingVerbosity`, whose toggles are the splitting diagnostics, not the leaf's. `inner_verbosity(verbose)` is what `init` hands OrdinaryDiffEq leaves, now reachable for custom leaves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RWfoaMxJzyy72Q7MzHEfYX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Float32time span could not be integrated since 0.4.2:dtmaxdefaults to the span length in the time type whiledtmindefaulted toeps(Float64), leavingIntegratorOptionswith no common type parameter. Both bounds are now converted to the node's time type at construction, witheps(T)as the floating-point default, and the struct carries no defaults of its own.A leaf integrator built from
config.values.verboseholds the splitting node'sOperatorSplittingVerbosity, whose toggles are the splitting diagnostics, not the leaf's.inner_verbosity(verbose)is whatinithands OrdinaryDiffEq leaves, now reachable for custom leaves.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.