Repository navigation
Port MTK test constructions from deprecated ODESystem to System - #572
Merged
ChrisRackauckas merged 1 commit intoOct 8, 2026
Merged
Conversation
ModelingToolkit deprecates ODESystem(...) in favor of System(...), so the two remaining ODESystem calls in the kernel-DE DAE testset abort the CPU group when run under --depwarn=error. The rest of the file already uses System; this brings the two stragglers in line with the same equations, parameters, and defaults. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <noreply@cognition.ai> Agent-Harness: Devin CLI 3000.11.3 Agent-Model: swe-2-high Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/gpu-fixes/log.txt on amdci2
ChrisRackauckas
marked this pull request as ready for review
October 8, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelingToolkit deprecates
ODESystem(args...; kwargs...)in favor ofSystem(...), soGROUP=CPUtests abort under--depwarn=erroron the two remainingODESystemcalls intest/gpu_kernel_de/stiff_ode/gpu_ode_modelingtoolkit_dae.jl(the "Host symbolic setter" and "MTK Pendulum DAE" testsets). This PR swaps both toSystemwith identical equations, parameters, and defaults — the rest of the file already usesSystem.Verification
Machine has no NVIDIA GPU; verified on the CPU backend only.
Red before (on master,
4f726d5+b6ae953):Green after (this branch, same command):
Every testset in the file (84 tests total; CUDA CI on this PR reports the same 84) passes; exit code 0.
runic --inplacemade no further changes andtyposis clean on the file.Not verified
@testsetbodies that run identically on every backend, and the file already usesSystemin four other testsets.docs/src/tutorials/modelingtoolkit.mdstill spells the same deprecatedODESystemin an@example(only exercised by the docs build on a GPU runner) — left alone to keep this PR test-only.ext/CUDAExt.jlstill calls deprecatedCUDA.CUBLAS.getrf_strided_batched!(warning seen during QA precompile; CUDA-only path, not hit on CPU). Reported, deliberately not changed here.Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
Systemis a strict rename ofODESystemin current ModelingToolkit and is already used elsewhere in the same file.--depwarn=errorfailure reproduced on master and shown passing on this branch (CPU backend).--depwarn=yes, so the failure fixed here only shows under--depwarn=error.🤖 Generated with Devin CLI 3000.11.3 (model: swe-2-high). Local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/gpu-fixes/log.txt on amdci2.