Migrate standards table to shared tablesort library - #156
Merged
Conversation
Replaces the bespoke sort/icon script in standards-table-sort.html with the shared tristen/tablesort library synced from components - one less copy of the same hand-rolled sort+icon logic that also lives in scangov's profile_table.html and (until now) my.scangov.com. Header icon markup simplified from the three-span sort-neutral/asc/desc pattern to the CSS-driven version, since @11ty/font-awesome rewrites these <i> tags into SVG sprites at build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the bespoke sort/icon script in standards-table-sort.html with the shared tristen/tablesort library synced from components - one less copy of the same hand-rolled sort+icon logic that also lives in scangov's profile_table.html and (until now) my.scangov.com. Header icon markup simplified from the three-span sort-neutral/asc/desc pattern to the CSS-driven version, since @11ty/font-awesome rewrites these tags into SVG sprites at build time.