Skip to content

ci(themes): improve quality gates and report publishing - #68

Merged
salahmyn merged 4 commits into
feature/quality-gates-twig-parity-auditfrom
feature/SAL-3553-enhance-ci-cd-quality-gates
Oct 27, 2026
Merged

salahmyn merged 4 commits into
feature/quality-gates-twig-parity-auditfrom
feature/SAL-3553-enhance-ci-cd-quality-gates

Conversation

@salahmyn

Copy link
Copy Markdown
Member

Summary

Ports the quality-gate checks of checkout-react's .github that apply to this repo.

  • ci.yml: static (typecheck, lint, format, manifest, knip), unit with the coverage floor, build with bundle size, a Testing Ready verdict and a Test Reports index.
  • Coverage and bundle size are published to the shared tests-reports worker (SallaApp/checkout-tests-reports/publish and finalize).
  • pr-gates.yml, pr-gates-merge-group.yml, pr-gates-rerun.yml with scripts/ci/prGates* and their tests.
  • Shared .github/actions/setup, plus docs/ci.md.

Not ported (nothing to run here): Storybook baselines, Figma visual, E2E nightly, API drift, deploy.

Verification

typecheck, lint (0 errors), format:check, knip, build and the new script tests pass locally.

Setup needed

Repository secrets R2_REPORTS_ACCESS_KEY_ID, R2_REPORTS_SECRET_ACCESS_KEY, R2_REPORTS_ENDPOINT, REPORTS_BASE_URL. Publishing never blocks a merge if they are missing. RUNS_ON is optional and falls back to ubuntu-latest.

Closes SAL-3553

…SAL-3553)

Adds the PR gates workflows and scripts, the shared setup action, and a tiered CI with Testing Ready and test reports published to the shared reports worker.

Made-with: agent
Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Oct 27, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository.

@sallainternalbot
sallainternalbot Bot marked this pull request as draft October 27, 2026 08:25
@salahmyn
salahmyn marked this pull request as ready for review October 27, 2026 09:02
salahmyn and others added 3 commits October 27, 2026 09:05
…L-3553)

Typecheck needs the generated route tree, so it runs after the build. PR gates now reports GitHub's error message and sends a User-Agent.

Made-with: agent
Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
…L-3553)

This repository is public: remove the use of private Salla actions, the reports worker and the org-bot PR gates. The CI now uses public actions only and posts one summary comment on the pull request.

Made-with: agent
Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
…mary (SAL-3553)

The organization IP allow list rejects REST calls from GitHub-hosted runners (HTTP 403).

Made-with: agent
Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
@salahmyn salahmyn changed the title ci(themes): port checkout-react quality gates and report publishing ci(themes): improve quality gates and report publishing Oct 27, 2026
@salahmyn
salahmyn merged commit 9bee8b2 into feature/quality-gates-twig-parity-audit Oct 27, 2026
7 checks passed
@salahmyn
salahmyn deleted the feature/SAL-3553-enhance-ci-cd-quality-gates branch October 27, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant