Repository navigation
Conversation
Sizes the client build (gzip and brotli per chunk, total JS and CSS) against size-budget.json and writes dist/size-report.json. Made-with: agent Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
Member
Author
|
@greptileai please review this pull request. |
Member
Author
|
This branch conflicts with the base branch |
Member
Author
|
@greptileai review |
salahmyn
marked this pull request as ready for review
October 27, 2026 10:56
…k (SAL-3524) Resolve the package.json conflict, drop every embedded hash from chunk names, reject builds with no JS assets, and add tests for the checker. Made-with: agent Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
…3524) `sort | head` under bash pipefail makes sort exit 2 when head closes the pipe early. awk reads all input, so sort finishes cleanly. Made-with: agent Co-authored-by: mc-agents[bot] <298817976+mc-agents[bot]@users.noreply.github.com>
greptile-apps
Bot
dismissed
their stale review
October 27, 2026 11:14
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
|
Automatic reviews are disabled for this repository. |
salahmyn
merged commit Oct 27, 2026
5f3e29e
into
feature/quality-gates-twig-parity-audit
7 checks passed
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
pnpm size: runs the production build, thenscripts/check-bundle.mjsmeasures every JS/CSS file indist/client/assets(gzip level 9 and brotli), groups by chunk name without the content hash, and compares with the committedsize-budget.json.dist/size-report.jsonfor CI to upload later.pnpm size:updaterebuilds and rewrites the budget when growth is intended.scripts/*.mjs.Verification
pnpm sizeon the base branch: exit 0 (total JS 415.3 kB gzip vs budget 436.1 kB).import * as ts from 'typescript'added toapp/router.tsx(reverted afterwards): exit 1.ProductDetails.test.tsx(localStorage.clearundefined) also fail on the unmodified base branch when run on Node 26 locally; the repo pins Node 22 in CI.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues remain.Summary
Adds
pnpm sizeto build the theme and check compressed JS and CSS sizes against committed limits.Reviews (3) · Last reviewed commit: "ci(devops): merge the base branch and ad..." · Reviewed by Greptile