fix(vscode): honor SFCC_CONFIG for instance config resolution

.changeset/vscode-sfcc-config-env.md

@@ -0,0 +1,5 @@
+---
+'b2c-vs-extension': patch
+---
+
+Honor the `SFCC_CONFIG` environment variable when resolving instance configuration. Previously the extension only looked for a `dw.json` in the workspace folder and ignored a global `dw.json` referenced by `SFCC_CONFIG`, so projects that relied on that env var (e.g. alongside a project `.env`) resolved to "No B2C Commerce instance configured". The extension now threads `SFCC_CONFIG` through as the explicit config path, matching the CLI's `--config` flag.

packages/b2c-vs-extension/package.json

@@ -2278,7 +2278,7 @@
     "@types/react-dom": "18.3.1",
     "@types/vscode": "^1.105.1",
     "@vscode/test-cli": "^0.0.12",
-    "@vscode/test-electron": "^2.5.2",
+    "@vscode/test-electron": "^3.1.0",
     "@vscode/vsce": "^3.9.1",
     "c8": "catalog:",
     "esbuild": "^0.24.0",

packages/b2c-vs-extension/src/config-provider.ts

@@ -326,7 +326,17 @@ export class B2CExtensionConfig implements vscode.Disposable {
         }
       }
 
-      const config = await resolveConfig({}, {workingDirectory, sourcesBefore: [new EnvSource()]});
+      // Honor SFCC_CONFIG (an explicit dw.json path), the same env var the CLI
+      // exposes via its `--config` flag. This is a file *path*, not a config
+      // field, so EnvSource can't carry it — it must be threaded through as
+      // `configPath`. Read it after the .env load so a project .env can set or
+      // override it, matching CLI precedence. Falls back to workingDirectory/dw.json.
+      const configPath = process.env.SFCC_CONFIG || undefined;
+      if (configPath) {
+        this.log.appendLine(`[Config] Using explicit config path from SFCC_CONFIG: ${configPath}`);
+      }
+
+      const config = await resolveConfig({}, {workingDirectory, configPath, sourcesBefore: [new EnvSource()]});
       this.config = config;
 
       if (!config.hasB2CInstanceConfig()) {

packages/b2c-vs-extension/src/test/config-provider.test.ts

@@ -4,6 +4,8 @@
  * For full license text, see the license.txt file in the repo root or http://www.apache.org/licenses/LICENSE-2.0
  */
 import * as assert from 'assert';
+import * as fs from 'fs';
+import * as os from 'os';
 import * as path from 'path';
 import * as vscode from 'vscode';
 import {B2CExtensionConfig} from '../config-provider.js';
@@ -56,4 +58,37 @@ suite('B2CExtensionConfig workspace discovery', () => {
       log.dispose();
     }
   });
+
+  test('honors SFCC_CONFIG (global dw.json path) over the workspace dw.json', async () => {
+    // Regression: the extension previously ignored SFCC_CONFIG (a dw.json *path*,
+    // as exposed by the CLI's --config flag) and only ever loaded a dw.json from
+    // the workspace folder. A project relying on a global dw.json via SFCC_CONFIG
+    // resolved to "No B2C Commerce instance configured".
+    const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'b2c-sfcc-config-'));
+    const globalDwJson = path.join(dir, 'dw.json');
+    fs.writeFileSync(globalDwJson, JSON.stringify({hostname: 'global-config.invalid', username: 'u', password: 'p'}));
+
+    const previous = process.env.SFCC_CONFIG;
+    process.env.SFCC_CONFIG = globalDwJson;
+
+    const log = vscode.window.createOutputChannel('B2C Config SFCC_CONFIG Test');
+    const provider = new B2CExtensionConfig(log);
+
+    try {
+      await provider.ensureResolved();
+      const instance = provider.getInstance();
+      assert.ok(instance, 'expected an instance resolved from SFCC_CONFIG');
+      assert.strictEqual(instance.config.hostname, 'global-config.invalid');
+      assert.strictEqual(provider.getConfigError(), null);
+    } finally {
+      provider.dispose();
+      log.dispose();
+      if (previous === undefined) {
+        delete process.env.SFCC_CONFIG;
+      } else {
+        process.env.SFCC_CONFIG = previous;
+      }
+      fs.rmSync(dir, {recursive: true, force: true});
+    }
+  });
 });