Fix reward kit redemption for items with multiple enchants#2
Merged
iphonetips1 merged 1 commit intoMar 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cannot convert direct holder to bukkit representationon newer Paper/Purpur (1.21) builds.Description
claim-itemsmap for bothenchantsandenchantmentskeys and remove them from the map prior to callingItemBuilder.create(...).key:levelstring forms and resolves both namespaced IDs and legacy enchant names viaNamespacedKeyandEnchantment.getByName(...).Enchantment -> levelpairs directly to the resultingItemStackusingaddUnsafeEnchantment(...)to avoid the AxAPI conversion path that crashes on 1.21.extractEnchantments,addEnchantmentsFromValue,addParsedEnchantment,resolveEnchantment, andapplyEnchantmentsinRewardGuito encapsulate the logic.Testing
mvn -q -DskipTests compile, which failed in this environment due to Maven Central returning HTTP 403 so full compile validation could not complete.git status --shortwhich succeeded and committed the change withgit commit.IllegalArgumentException.Codex Task