Tile Volume Persistence#17
Merged
Merged
Conversation
persist committed per-tile playback volumes in settings and restore them on tile creation
7w1
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Persist each tile's playback volume and restore it when the tile is created again.
New tileVolumes setting storing committed volume levels by the participant's RTC backend identity (userId:deviceId), with a :screen-share suffix so screen share audio keeps its own volume separate from the participant's voice.
createVolumeControls gains an initialVolume input and an onVolumeCommitted callback; the remote user media and remote screen share view models use them to restore and save volumes.
Only non-default volumes are stored, resetting a tile to full volume removes its entry.
Motivation and context
Per-tile volume adjustments were lost whenever the tile was recreated, so they had to be redone every call (and mid-call on reconnects), incredibly annoying imo...
Now they are kept when leaving and rejoining, volume levels are saved on slider release.
Muting a tile or releasing the slider at zero keeps the previously saved volume, matching the existing unmute behavior of returning to the last committed volume.
Screenshots / GIFs
N/A
Tests
Added unit tests for saveTileVolume and a new VolumeControls.test.ts covering initial volume, commit reporting, and mute interactions.
Typecheck and the full unit suite pass locally (node 24, mirroring CI).