Feat: Week9/nonshaman-m2 - #87
Open
nonshaman wants to merge 35 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Revert 37 week4/nonshaman m1
…an-m1 Revert 83 revert 37 week4/nonshaman m1
Feat: Week4/nonshaman-m2
Feat: Week4/nonshaman m3
Week5/nonshaman-m1
Week5/nonshaman-m2
Week5/nonshaman-m3
Feat: Week6/nonshaman-m1
Feat: Week6/nonshaman-m2
Feat: Week7/nonshaman-m1
Feat: Week7/nonshaman-m2
Feat: Week8/nonshaman-m1
Feat: Week8/nonshaman-m2
Feat: Week8/nonshaman-m3
yewon20804
reviewed
Jun 2, 2026
yewon20804
left a comment
Collaborator
There was a problem hiding this comment.
9주차 미션 2도 수고하셨습니다 ! 이번에는 Modal Slice 활용하여, 모달 기능을 추가해보는거였는데요 ! 잘 작성해주셨고 아래 코멘트 확인 부탁드립니다
1. week9/src/slices/modalSlice.ts — export default 불필요한 변수 선언
// 이전
const modalReducer = modalSlice.reducer;
export default modalReducer;
// 수정
export default modalSlice.reducer;
변수에 담지 않고 carSlice.ts처럼 직접 export하셔도 됩니다 ! 그리고 이 방식이 더 일방적입니다 !
2. week9/src/components/Modal.tsx — 인라인 스타일 사용
현재 배경 오버레이에만 인라인 스타일을 사용하고, 나머지는 tailwind로 작성해주셨기 때문에 배경 오베리이도 Tailwind로 통일하면 좋을 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 주차 / 미션
📌 작업 내용
📸 스크린샷
✅ 체크리스트