Skip to content

Fix warning tab iteration #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andresin87 merged 3 commits into from
Oct 20, 2026
Merged

Fix warning tab iteration #2987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55f7b0f
feat(components/molecule/tabs): add support for spreading additional …
andresin87 Oct 20, 2026
5ae6aa8
feat(components/molecule/tabs): add support for spreading additional …
andresin87 Oct 20, 2026
da5c6bd
Merge branch 'master' into fix-warning-tab-iteration
andresin87 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions components/molecule/tabs/src/components/MoleculeTabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ const MoleculeTabs = ({
type = TYPES.HORIZONTAL,
variant = VARIANTS.CLASSIC,
tabsJustifyContent = TABS_JUSTIFY_CONTENT.FLEX_START,
keepTabsContentMounted = false
keepTabsContentMounted = false,
...props
}) => {
const className = cx(BASE_CLASS, {
[`${BASE_CLASS}--${variant}`]: variant,
Expand Down Expand Up @@ -136,15 +137,22 @@ const MoleculeTabs = ({
numTab,
id,
onChange,
ref: el => (tabRefs.current[index] = el) // Assign ref to each MoleculeTab
ref: el => (tabRefs.current[index] = el), // Assign ref to each MoleculeTab
key: index
})
})

const tabContent = childrenArray.reduce((activeContent, child) => {
const tabContent = childrenArray.reduce((activeContent, child, currentIndex) => {
if (child) {
const {children: childrenChild, active, numTab} = child.props
activeContent.push(
<Wrapper id={id} keepTabsContentMounted={keepTabsContentMounted} isActive={active} numTab={numTab}>
<Wrapper
id={id}
keepTabsContentMounted={keepTabsContentMounted}
isActive={active}
numTab={numTab}
key={currentIndex}
>
{childrenChild}
</Wrapper>
)
Expand All @@ -153,7 +161,7 @@ const MoleculeTabs = ({
}, [])

return (
<div className={className}>
<div className={className} {...props}>
<ul
ref={outerRef}
className={CLASS_SCROLLER}
Expand Down
4 changes: 2 additions & 2 deletions components/molecule/tabs/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe(json.name, () => {
expect(container.innerHTML).to.not.have.lengthOf(0)
})

it('should NOT extend classNames', () => {
it('should extend classNames', () => {
// Given
const props = {
className: 'extended-classNames'
Expand All @@ -90,7 +90,7 @@ describe(json.name, () => {
const findClassName = findSentence(props.className)

// Then
expect(findClassName(container.innerHTML)).to.be.null
expect(findClassName(container.innerHTML)).to.not.be.null
})

it('should display the active content', () => {
Expand Down
Loading