Add SIC default credential password change prompt + migration - #19
Open
acidphantasm wants to merge 1 commit into
Open
Add SIC default credential password change prompt + migration#19acidphantasm wants to merge 1 commit into
acidphantasm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh install behaviour:
Existing install behaviour:
This is also adjusted so the migration for the new model happens after the migration for plaintext passwords, so if they dont want to delete the credential.json but simply want to update the password in the file to plaintext they won't prompt again, it just hashes that password and then doesn't require a password change unless they flip the bool for the password change requirement to true.