Repository navigation
Implement #instVarNamed: prim, fix SClass' handling of number of fields - #43
Merged
Merged
Conversation
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
At some point, we changed how fields from superclasses are dealt with, and these two methods were overlooked in that change. Since fields from the superclass are integral part of the class at this point, these two methods are much simpler. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#instVarNamed:primitive was not yet implemented, and revealed a bug inSClass.At some point, we changed how the fields of superclasses are handled.
We now require the superclass to be loaded, and simply make superclass fields part of the classes fields. But when this change was done, we missed
getInstanceFieldName()andgetNumberOfInstanceFields(). This is now fixed.There are a few more GitHub Action fixes to keep things working.