Skip to content

docs: identifier example in color settings preview (#467 #342)#482

Closed
SJrX wants to merge 1 commit into
issue-345-12from
issue-345-13
Closed

docs: identifier example in color settings preview (#467 #342)#482
SJrX wants to merge 1 commit into
issue-345-12from
issue-345-13

Conversation

@SJrX

@SJrX SJrX commented Jun 21, 2026

Copy link
Copy Markdown
Owner

What

The color-settings preview (Settings → Editor → Color Scheme → Unit Files (systemd)) had grammar examples for enum / literal / operator, but none for Identifier — so clicking "Value//Identifier (grammar)" highlighted nothing in the sample.

Tag the existing [Unit] Description= value with the identifier tag. Description= is config_parse_unit_string_printf → a free-form RegexTerminal → role IDENTIFIER, so it's an accurate example, and clicking the Identifier attribute now highlights it.

Stacked on #481 (issue-345-12). One-line demo-text change.

Refs #467 #342

🤖 Generated with Claude Code

… preview (#467 #342)

The color-settings preview had grammar examples for enum/literal/operator but none for
the Identifier role, so clicking "Value//Identifier (grammar)" highlighted nothing.
Tag the [Unit] Description= value (a config_parse_unit_string_printf identifier) so the
role has a visible example.

Refs #467 #342

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Test Results

1 142 tests  ±0   1 142 ✅ ±0   48s ⏱️ -1s
  303 suites ±0       0 💤 ±0 
  303 files   ±0       0 ❌ ±0 

Results for commit 788fd59. ± Comparison against base commit 320439c.

@SJrX

SJrX commented Jun 29, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #497 (squash-merged into 242.x as a1daaf9), which bundled the value-coloring stack (#479 engine + #480 render + #482 preview + #483 free-form) re-cut against current 242.x. Closing.

@SJrX SJrX closed this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant