fix: [OpenAPI] Api client method with oneOf primitive param stays simplified in OpenAPI generator 7.22.0#1179
Open
CharlesDuboisSAP wants to merge 5 commits into
Open
fix: [OpenAPI] Api client method with oneOf primitive param stays simplified in OpenAPI generator 7.22.0#1179CharlesDuboisSAP wants to merge 5 commits into
CharlesDuboisSAP wants to merge 5 commits into
Conversation
…plified in OpenAPI generator 7.22
…plified in OpenAPI generator 7.22
…plified in OpenAPI generator 7.22
Contributor
Author
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
A better solution could be found by finding what changed from the openAPI generator 7.21.0 to 7.22.0. Especially in the org.openapitools.codegen classes containing usages of getParameter(). You can debug the existing modified unit test of this PR to explore the suspected OpenAPI classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The OpenAPI generator
7.22.0broke generated api classes.Feature scope:
DataModelGeneratorIntegrationTest.integrationTests()for enumAPI_CLASS_VENDOR_EXTENSION_YAML.GenerationConfigurationConverter.preprocessSpecification()(has been commented out)Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated