Skip to content

[IAS] Dynamically Resolve IAS Host On-Demand#1177

Merged
MatKuhr merged 7 commits into
mainfrom
feat/dynamic-ias-url-resolver
May 26, 2026
Merged

[IAS] Dynamically Resolve IAS Host On-Demand#1177
MatKuhr merged 7 commits into
mainfrom
feat/dynamic-ias-url-resolver

Conversation

@MatKuhr
Copy link
Copy Markdown
Member

@MatKuhr MatKuhr commented May 21, 2026

Context

This PR enhances the OAuth2Service to dynamically resolve the IAS tenant host, if not given.

Feature scope:

  • Load BTP API URL from service binding, if present
  • HTTP call to /tenantLoginInfo to resolve IAS tenant host

Please note: No public API is exposed for this.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@MatKuhr MatKuhr added the please review Request to review a pull request label May 21, 2026
@MatKuhr MatKuhr marked this pull request as ready for review May 21, 2026 16:36
+ "Ensure your IAS service binding contains the BTP tenant API URL in the property 'btp-tenant-api'.");
}
return subdomain;
return iasTenantHostResolver.resolve(btpTenantApiUri, tenant.getTenantId());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question)

What's the impact of the additional HTTP request?

  • assumed duration / timeout
  • which http connection pool
  • considered result caching?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single connection pool since there is only one connection, the URL is fixed for the BTP region. Requests should be fast, but no timeout & caching since this code is intended as temporary workaround.

Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things :)

MatKuhr and others added 3 commits May 26, 2026 09:08
…dk/cloudplatform/connectivity/IasTenantHostResolver.java

Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MatKuhr MatKuhr merged commit 9c6739e into main May 26, 2026
13 checks passed
@MatKuhr MatKuhr deleted the feat/dynamic-ias-url-resolver branch May 26, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please review Request to review a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants