Skip to content

feat: revisit beta annotations - #1045

Merged
vladimir-a-sap merged 31 commits into
v2from
revisit-beta-annotations
Sep 25, 2026
Merged

vladimir-a-sap merged 31 commits into
v2from
revisit-beta-annotations

Conversation

@vladimir-a-sap

@vladimir-a-sap vladimir-a-sap commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Context
https://github.com/SAP/ai-sdk-java-backlog/issues/432

related documentation task: https://github.com/SAP/ai-sdk-java-backlog/issues/438

related documentation update pr: SAP/ai-sdk#768

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Relevant E2E tests are green (at least locally)
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK (not applicable, java code only)
  • Documentation updated
  • Release notes updated (seems to be irrelevant for this particular task, documentation will be updated instead)

Comment thread core/src/main/java/com/sap/ai/sdk/core/AiCoreService.java

@vladimir-a-sap vladimir-a-sap left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added clarifications on proposed changes

Comment thread core/src/main/java/com/sap/ai/sdk/core/common/ClientStreamingHandler.java Outdated
Comment thread core/src/main/java/com/sap/ai/sdk/core/AiCoreService.java
Comment thread orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentFilter.java Outdated

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Beta annotations are still there.
Also release notes are needed for the functions we removed like JSON or createFilter()

@vladimir-a-sap

Copy link
Copy Markdown
Contributor Author

Some Beta annotations are still there. Also release notes are needed for the functions we removed like JSON or createFilter()

addressed.

  • left only one @beta annotation on RealtimeParamVoice where I'm not sure that the factory method is stable (method was added by request from someone, can't recall who asked)
  • made private and @deprecated OpenAiClient.withApiVersion. Quick removal revealed that many tests fail without it. Further research needed on why and how to fix.

@CharlesDuboisSAP
CharlesDuboisSAP added this pull request to stack #1073 September 24, 2026 11:20
Comment thread docs/release_notes.md Outdated
Comment thread docs/release_notes.md Outdated
Comment thread docs/release_notes.md Outdated
Comment thread docs/release_notes.md Outdated
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
@vladimir-a-sap
vladimir-a-sap removed this pull request from stack #1073 September 25, 2026 07:49
@vladimir-a-sap
vladimir-a-sap merged commit 97c3a3b into v2 Sep 25, 2026
7 checks passed
@vladimir-a-sap
vladimir-a-sap deleted the revisit-beta-annotations branch September 25, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants