Skip to content

Fix GHA access to private repos in org #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremyestein wants to merge 3 commits into from
Closed

Fix GHA access to private repos in org #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b1c79a
Use documented method of accessing private repos in the org, but I don't
jeremyestein Sep 10, 2026
a11b31c
emap-setup tests also needs a token for cloning private repos
jeremyestein Sep 10, 2026
aa61c53
Switch to the read-only keys as we only need read-only access
jeremyestein Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/comment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ jobs:
comment:
runs-on: ubuntu-latest
steps:
- name: Generate GitHub App Token
id: generate-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.SAFEHR_READ_ONLY_WORKER_ID }}
private-key: ${{ secrets.SAFEHR_READ_ONLY_WORKER_KEY }}
- name: Checkout documentation
uses: actions/checkout@v4
with:
repository: SAFEHR-data/internal_emap_documentation
token: ${{ secrets.GH_PAT_READ_AND_COMMENT }}
token: ${{ steps.generate-token.outputs.token }}
ref: main
- id: get-pr-checklist
name: Get PR checklist
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/emap-setup-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@ jobs:
emap-setup-tests:
needs: [filter]
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GH_PAT_READ_AND_COMMENT }}
if: needs.filter.outputs.emap-setup == 'true'
steps:
# emap-setup test performs clones of private repos as part of the test, so
# a token is needed to be able to do that
- name: Generate GitHub App Token
id: generate-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.SAFEHR_READ_ONLY_WORKER_ID }}
private-key: ${{ secrets.SAFEHR_READ_ONLY_WORKER_KEY }}
- uses: actions/checkout@v3
- name: Set up python
uses: actions/setup-python@v5
Expand All @@ -42,6 +48,8 @@ jobs:
run: |
python -m pip install -r emap-setup/requirements.txt
- name: Run tests
with:
token: ${{ steps.generate-token.outputs.token }}
run: |
cd emap-setup
pytest --cov=./ --cov-report=term
Loading