Repository navigation
test(core,server): make the suite pass as root, under a slow init, and on Linux rustdoc - #8
Merged
Merged
Conversation
…d on Linux rustdoc Four findings from running the backend CI gate (clippy, rustdoc, the hermetic suite) on a Linux container, three of which the macOS-hosted jobs never meet: - Two tests observe a failed read or write through `chmod`, which root reads and writes past; they now return early as root, through a shared `testutil::running_as_root`, as the fs_scan tests already do inline. - The store's cancel-while-forking test probed the process group once, 100 ms after the kill; killed helpers linger as zombies until init reaps them, which a container without an init does slowly, and Linux counts a zombie as signalled. The probe now waits up to ten seconds, as the procgroup tests do; a real survivor sleeps thirty. - `settle_new_executable` read Linux's ETXTBSY (a child another test thread forked while the script was still open for writing holds that descriptor until it execs) as a script that does not run. It now retries that one error briefly, which is the first-run cost it exists to absorb. - A doc link to `ProxyConfig::from_system` resolves only where the item is built (macOS or test); rustdoc with warnings denied failed on Linux. It is plain code text now. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRJ4sDknvQJ86tFvGydgpf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running the backend CI gate (clippy, rustdoc with warnings denied, the hermetic suite for
clew-core,clew-serverandclew-protocol) on a Linux container turned up four failures the macOS-hosted jobs never meet. All four fixes are in tests and docs; no product logic changes.statefile::tests::a_store_whose_read_failed_is_not_a_refusalandclew-server'sstate::tests::a_refused_merge_and_a_failed_one_are_told_apartobserve a failed read or write throughchmod, which root reads and writes past. They now return early as root, through a new sharedtestutil::running_as_root(), matching what thefs_scantests already do inline.lsp::store::tests::a_cancel_while_the_installer_forks_stops_every_helperprobed the process group once, 100 ms after the kill. Killed helpers linger as zombies until init reaps them (a container without an init does so slowly), and Linux counts a zombie as signalled. The probe now waits up to ten seconds, as theprocgrouptests already do; a real survivor is asleep 30, well past that.settle_new_executablehits Linux'sETXTBSYin a parallel suite. A child that another test thread forked while the script was still open for writing holds that descriptor until it execs, and exec of the file fails meanwhile. The helper now retries that one error briefly; absorbing first-run costs is what it exists for.net.rslinkedProxyConfig::from_system, which is only built on macOS or under test, socargo doc -D warningsfailed on Linux. It is plain code text now.Verification
On Linux, for
clew-core,clew-serverandclew-protocol:scripts/hermetic-test.shcargo clippy --all-targets -- -D warningscargo doc --no-deps --document-private-itemswith-D warningscargo fmt --all -- --check🤖 Generated with Claude Code
https://claude.ai/code/session_01WRJ4sDknvQJ86tFvGydgpf
Generated by Claude Code