Repository navigation
docs: every number in the README, re-measured - #2
Merged
Merged
Conversation
The README is the one place that claims numbers without showing the command, so each was run: * `cargo test --workspace` is 179 tests, not 149. * `cargo xtask diff` covers nine cases, not six — the page said nine in one place and six in three others. Six of the nine are real mission downlinks; byte_order, mil_1750a and context_calibrators are constructed, because no mission file in reach sets `byteOrder` or carries a `<ContextCalibratorList>`. * The digest is over 19 025 packets, not ~17 000. * The sample output was from a run two versions old. Replaced with a real one. And `codegen \\` in the "Try it" block was a double backslash, so pasting the command fed the shell a literal backslash and then a stray path. One backslash. Verified unchanged: 19 bundled definitions, 29 inline end-to-end cases in decode_inline.rs, 7200 JPSS packets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README is the one page that claims numbers without showing the command that produced
them, so each was run.
cargo test --workspacecargo xtask diffcasesThe three constructed cases are
byte_order,mil_1750aandcontext_calibrators: nomission file in reach sets
byteOrderor carries a<ContextCalibratorList>, so there is norecorded telemetry to put in front of the reference.
Separately, the
codegenline in the "Try it" block ended in a double backslash — pasting itfed the shell a literal backslash and then a stray path.
Verified unchanged: 19 bundled definitions, 29 inline end-to-end cases, 7200 JPSS packets.