Repository navigation
test: the shipped layout opens on three full plots - #5
Merged
Merged
Conversation
The README and the v0.1.0 notes both promise that the replay opens on GPS position, velocity and the attitude quaternion. Nothing checked it, and the way it would fail is silent: a layout resolves parameters by qualified name, and a name the definition does not declare is dropped with a note rather than an error, because a station that refused to start over a stale layout would be unusable exactly once per mission. So a typo in the shipped file leaves a visitor looking at the empty window the file exists to prevent, and the only sign is a line in the event log. The test restores the layout before the first packet — the order App::new uses, since a parameter's history begins when it is watched — and then asserts all ten plotted parameters hold 7200 points once the recording is decoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README and the v0.1.0 notes both promise that
xtce-gs replay … --repeatopens on GPSposition, velocity and the attitude quaternion. Nothing checked it, and the way it would fail
is silent.
A layout resolves parameters by qualified name, and a name the definition does not declare is
dropped with a note, not an error — a station that refused to start over a stale layout
would be unusable exactly once per mission. So a typo in the shipped file leaves a visitor
looking at the empty window the file exists to prevent, and the only sign is one line in the
event log nobody reads on first contact.
The test restores the layout before the first packet arrives — the order
App::newuses,because a parameter's history begins when it is watched — then asserts all ten plotted
parameters hold 7 200 points once the recording is decoded. It also asserts
note == None,so a layout that loads but drops half of itself fails here rather than looking fine.
532 tests, fmt and clippy clean.