Repository navigation
fix(gui): the "and N more" notice was drawn where nothing can see it - #14
Merged
Merged
Conversation
The parameter list caps at 512 matches and then says how many it left out. It said it below the clip rect, every time, so an operator searching a definition of nine thousand parameters saw 512 rows and nothing to tell them the other 8 981 existed — which reads as a search that found everything. `ScrollArea::auto_shrink([false, false])` takes every remaining point of height, so a line added after it is laid out past the bottom edge. The notice is a bottom strip now, claiming its height before the scroll area takes the rest. No test covers this and none can: it is a property of where a thing is drawn, which is the gap `TODO(gs-gui-app)` describes. What covers it is that the station can now photograph itself — `--screenshot` against CTIM shows the line present where it was absent before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter list caps at 512 matches and then says how many it left out. It said it below
the clip rect, every time — so an operator searching a definition of nine thousand parameters
saw 512 rows and nothing to tell them the other 8 981 existed, which reads as a search that
found everything.
ScrollArea::auto_shrink([false, false])takes every remaining point of height, so a lineadded after it is laid out past the bottom edge and never drawn. The notice is a bottom strip
now, claiming its height before the scroll area takes the rest.
Before and after, same command, CTIM's 9 493 parameters:
Before: the list runs off the bottom edge. After:
… and 8981 more, narrow the search.No test covers this and none can — it is a property of where a thing is drawn, which is
the gap
TODO(gs-gui-app)describes from the other side. What covers it instead is that thestation can photograph itself now.
542 tests, fmt and clippy clean.