Repository navigation
chore: deny missing_docs again - #11
Merged
Merged
Conversation
Removing it was a measurement, and the measurement said it was not where the comment volume came from: its floor is one summary line per public item, 793 lines, 3% of the workspace. The volume is in the paragraphs under those summaries, and those turned out to be API contract — what a frame length is measured between, that a UDP read never returns Ok(0), which lock is held across what — rather than prose that could go. So the lint costs nothing that was worth having and keeps the next public item from arriving without a sentence. Back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10.
Removing it was a measurement, and the measurement said it was not where the comment volume came from: the lint's floor is one summary line per public item — 793 lines, 3% of the workspace.
The volume sits in the paragraphs under those summaries, and those turned out to be API contract rather than prose: what a frame length is measured between, that a UDP read never returns
Ok(0), which lock is held across what, that a batch buffer is overwritten in full. A pass that trimmed them was written, run, and thrown away.So the lint costs nothing that was worth having, and it keeps the next public item from arriving without a sentence.