Skip to content

Report BINSEC error output even on success #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Nov 7, 2026
Merged

Report BINSEC error output even on success #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,19 +507,24 @@ fn run_job(mut job: Job) -> (Report, String) {
for line in stdout.lines() {
log.push_str(&format!(" {line}\n"));
}
// BINSEC can exit successfully with an unknown verdict while explaining
// discontinued paths (e.g. unsupported instructions) only on stderr.
for line in stderr.lines() {
log.push_str(&format!(" {line}\n"));
}

if !output.status.success() {
report.details.push(format!(
"binsec failed ({}): {}",
output.status,
stderr.trim()
));
log.push_str(&format!(" binsec failed ({}):\n{stderr}\n", output.status));
log.push_str(&format!(" binsec failed ({})\n", output.status));
return (report, log);
}

report.status = parse_status(&stdout).unwrap_or_else(|| {
log.push_str(&format!(" UNEXPECTED binsec output, stderr:\n{stderr}\n"));
log.push_str(" UNEXPECTED binsec output\n");
Status::Unknown
});
report.details = stdout
Expand Down
Loading