Skip to content

Add sntrup-kem#334

Open
mikelodder7 wants to merge 6 commits into
RustCrypto:masterfrom
mikelodder7:master
Open

Add sntrup-kem#334
mikelodder7 wants to merge 6 commits into
RustCrypto:masterfrom
mikelodder7:master

Conversation

@mikelodder7

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
Signed-off-by: Mike Lodder <redmike7@gmail.com>
@mikelodder7

Copy link
Copy Markdown
Contributor Author

@tarcieri ping

@tarcieri

Copy link
Copy Markdown
Member

Sorry for the belated review.

I think it would be good if you could implement the kem crate traits. We got that done for hqc-kem in #353 which also added no_alloc support which would be nice to have as well (note: frodo-kem still lacks kem trait impls too).

It looks like there are a number of SIMD optimizations that aren't being tested in CI. It would be good to copy the relevant CI configs from one of our other repos (using cross if/where necessary) so we can ensure those are tested in CI.

@mikelodder7

Copy link
Copy Markdown
Contributor Author

Good point, I'll add kem traits for frodoKem and this one. Won't be until later next week. Traveling atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants