Skip to content

SDKConfig.KeepAlive field is ignored in makeClient() #4

Description

@BGProjects

Bug Description

The SDKConfig struct has a KeepAlive field, but makeClient() function
ignores it and always passes false to New().

Code Location

sdk.go, line ~108-112:

client, err := New(RunwareConfig{
    APIKey:    cfg.APIKey,
    ConnAddr:  cfg.ConnAddr,
    KeepAlive: false,  // Should be: cfg.KeepAlive
})

**Expected Behavior**

makeClient() should use cfg.KeepAlive value instead of hardcoded false.

**Suggested Fix**

KeepAlive: cfg.KeepAlive,

**Impact**

Users cannot enable WebSocket keep-alive functionality through the SDK
configuration.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions