Conversation
PATCH already accepts appName, but deploy --name stayed create-only with no follow-up command. Rename updates the name in place and does not pin or roll workers.
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
secretfader
left a comment
There was a problem hiding this comment.
No bugs or risks, 2 nits. Help text matches the server: a name-only PATCH records version N+1, never pins or rolls, and is 200 in every status but deleting (409) and deleted (404). validateAppName matches the server pattern ^\S(.*\S)?$ apart from exotic edge whitespace (NBSP, \v), where the CLI is stricter. That is harmless.
deploy.go:L261: nit:deploy --name " padded"on create skipsvalidateAppName, so it zips and uploads the source (L319), then gets a server 422. CallvalidateAppNamewhen--nameis changed, beforebuildDeployArchive.
| if err := cmd.Execute(); err != nil { | ||
| t.Fatalf("rename: %v", err) | ||
| } | ||
| if patches != 1 { |
There was a problem hiding this comment.
nit: output is discarded, so dropping the output.Print in apps_rename.go still passes. Keep the stdout buffer and assert it contains wantName.
Summary
runware serverless apps rename <appId> <name>so a display name can change after create. The API already acceptsPATCH appName;--nameon deploy stays create-only.--nameon an update now points atapps renameinstead of a generic omit-it hint.Test plan
runware serverless apps rename my-app "Image generator"updates the display name and prints the apprunware serverless deploy ./app.py --id my-app --name "Other"on an existing app errors withapps renamename must start and end with a non-whitespace character)apps show my-appreflects the new name;appIdis unchanged