Skip to content

feat(serverless): add apps rename for the display name - #144

Open
Ryank90 wants to merge 1 commit into
rc/serverlessfrom
feat/serverless-apps-rename
Open

Ryank90 wants to merge 1 commit into
rc/serverlessfrom
feat/serverless-apps-rename

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add runware serverless apps rename <appId> <name> so a display name can change after create. The API already accepts PATCH appName; --name on deploy stays create-only.
  • A name-only update records a version and does not pin or roll workers. The application ID is immutable.
  • Passing --name on an update now points at apps rename instead of a generic omit-it hint.

Test plan

  • runware serverless apps rename my-app "Image generator" updates the display name and prints the app
  • runware serverless deploy ./app.py --id my-app --name "Other" on an existing app errors with apps rename
  • A padded or empty name is rejected locally (name must start and end with a non-whitespace character)
  • apps show my-app reflects the new name; appId is unchanged

PATCH already accepts appName, but deploy --name stayed create-only with no follow-up command. Rename updates the name in place and does not pin or roll workers.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0f3fca5a-0435-43d1-8550-0c5f6d6e2485

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@secretfader secretfader left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bugs or risks, 2 nits. Help text matches the server: a name-only PATCH records version N+1, never pins or rolls, and is 200 in every status but deleting (409) and deleted (404). validateAppName matches the server pattern ^\S(.*\S)?$ apart from exotic edge whitespace (NBSP, \v), where the CLI is stricter. That is harmless.

  • deploy.go:L261: nit: deploy --name " padded" on create skips validateAppName, so it zips and uploads the source (L319), then gets a server 422. Call validateAppName when --name is changed, before buildDeployArchive.

if err := cmd.Execute(); err != nil {
t.Fatalf("rename: %v", err)
}
if patches != 1 {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: output is discarded, so dropping the output.Print in apps_rename.go still passes. Keep the stdout buffer and assert it contains wantName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants