Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The schema, generated model, display path, and tests consistently support arbitrary JSON task outputs.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Serverless task outputs to support any JSON value throughout the generated client and CLI display.
Changes:
- Generalizes the OpenAPI
Task.outputschema and generated Go type. - Renders scalar task outputs.
- Adds coverage for scalar and list decoding.
| File | Description |
|---|---|
api/serverless/openapi.yaml |
Defines output as arbitrary JSON. |
internal/api/serverless/gen/client.gen.go |
Regenerates Task.Output as interface{}. |
internal/api/serverless/tasks_test.go |
Tests output decoding across task APIs. |
internal/cmd/serverless/display.go |
Formats arbitrary output values. |
internal/cmd/serverless/apps_tasks_test.go |
Tests scalar output rendering. |
Files not reviewed (1)
- internal/api/serverless/gen/client.gen.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The CLI's generated Serverless task client now decodes arbitrary JSON outputs, so task reads and completed async resubmissions can carry strings and lists without failing JSON decoding.
apps tasks showalso prints scalar outputs.Task.outputThis sync is needed before the task output contract update reaches dev.