fix(serverless): drop the concurrency flag the API no longer accepts - #138
Conversation
This change removes concurrency from the vendored serverless OpenAPI document and regenerates the client. It also removes the --concurrency flag from apps scale, the Concurrency row from the app display, the flag from the generated command docs, and the field from the test fixtures. The serverless API removes the field from its worker configuration, because no worker applies it (RUNSERV-911). After that change, the API rejects a request that contains concurrency with 422, so apps scale --concurrency would always fail. Release this change before the API change deploys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes consistently remove the obsolete field and update related code, documentation, and fixtures.
Review effort: Lite
Findings: None
What changed in this PR
Removes the obsolete serverless concurrency field and CLI flag to match the updated API contract.
Changes:
- Removes concurrency from OpenAPI and generated client types.
- Removes the
--concurrencyflag and display row. - Updates documentation, tests, and fixtures.
| File | Description |
|---|---|
internal/cmd/serverless/display.go |
Removes the concurrency display row. |
internal/cmd/serverless/display_test.go |
Updates display expectations. |
internal/cmd/serverless/deploy_test.go |
Updates app fixtures. |
internal/cmd/serverless/deploy_endpoints_test.go |
Updates endpoint fixtures. |
internal/cmd/serverless/apps_scale.go |
Removes concurrency flag handling. |
internal/cmd/serverless/apps_scale_test.go |
Removes obsolete flag coverage. |
internal/api/serverless/gen/client.gen.go |
Regenerates worker configuration types. |
internal/api/serverless/client_test.go |
Updates API response fixtures. |
docs/runware_serverless_apps_scale.md |
Removes the obsolete documented flag. |
api/serverless/openapi.yaml |
Removes concurrency from API schemas. |
Files not reviewed (1)
- internal/api/serverless/gen/client.gen.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This change removes concurrency from the vendored serverless OpenAPI document
and regenerates the client. It also removes the --concurrency flag from apps
scale, the Concurrency row from the app display, the flag from the generated
command docs, and the field from the test fixtures.
The serverless API removes the field from its worker configuration, because no
worker applies it (RUNSERV-911). After that change, the API rejects a request
that contains concurrency with 422, so apps scale --concurrency would always
fail. Release this change before the API change deploys.
Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com