Skip to content

fix(serverless): drop the concurrency flag the API no longer accepts - #138

Merged
danmrichards merged 1 commit into
rc/serverlessfrom
RUNSERV-911-remove-concurrency
Sep 24, 2026
Merged

danmrichards merged 1 commit into
rc/serverlessfrom
RUNSERV-911-remove-concurrency

Conversation

@danmrichards

Copy link
Copy Markdown
Collaborator

This change removes concurrency from the vendored serverless OpenAPI document
and regenerates the client. It also removes the --concurrency flag from apps
scale, the Concurrency row from the app display, the flag from the generated
command docs, and the field from the test fixtures.

The serverless API removes the field from its worker configuration, because no
worker applies it (RUNSERV-911). After that change, the API rejects a request
that contains concurrency with 422, so apps scale --concurrency would always
fail. Release this change before the API change deploys.

Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com

This change removes concurrency from the vendored serverless OpenAPI document
and regenerates the client. It also removes the --concurrency flag from apps
scale, the Concurrency row from the app display, the flag from the generated
command docs, and the field from the test fixtures.

The serverless API removes the field from its worker configuration, because no
worker applies it (RUNSERV-911). After that change, the API rejects a request
that contains concurrency with 422, so apps scale --concurrency would always
fail. Release this change before the API change deploys.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f2375352-569f-4005-af07-b0acb7d28ca8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed changes consistently remove the obsolete field and update related code, documentation, and fixtures.

Review effort: Lite
Findings: None

What changed in this PR

Removes the obsolete serverless concurrency field and CLI flag to match the updated API contract.

Changes:

  • Removes concurrency from OpenAPI and generated client types.
  • Removes the --concurrency flag and display row.
  • Updates documentation, tests, and fixtures.
File Description
internal/​cmd/​serverless/​display.go Removes the concurrency display row.
internal/​cmd/​serverless/​display_test.go Updates display expectations.
internal/​cmd/​serverless/​deploy_test.go Updates app fixtures.
internal/​cmd/​serverless/​deploy_endpoints_test.go Updates endpoint fixtures.
internal/​cmd/​serverless/​apps_scale.go Removes concurrency flag handling.
internal/​cmd/​serverless/​apps_scale_test.go Removes obsolete flag coverage.
internal/​api/​serverless/​gen/​client.gen.go Regenerates worker configuration types.
internal/​api/​serverless/​client_test.go Updates API response fixtures.
docs/​runware_serverless_apps_scale.md Removes the obsolete documented flag.
api/​serverless/​openapi.yaml Removes concurrency from API schemas.
Files not reviewed (1)
  • internal/api/serverless/gen/client.gen.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@danmrichards
danmrichards marked this pull request as ready for review September 24, 2026 13:45
@danmrichards
danmrichards merged commit b5115db into rc/serverless Sep 24, 2026
5 checks passed
@danmrichards
danmrichards deleted the RUNSERV-911-remove-concurrency branch September 24, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants