Skip to content

fix(serverless): set several environment variables in one rollout - #136

Merged
Ryank90 merged 3 commits into
rc/serverlessfrom
feat/serverless-env-batch
Sep 24, 2026
Merged

Ryank90 merged 3 commits into
rc/serverlessfrom
feat/serverless-env-batch

Conversation

@Ryank90

@Ryank90 Ryank90 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apps env set still sets one key with <key> --value or --value-file.
  • Repeatable --env KEY=VALUE and --env-file read the current set, merge those keys, and write it in one request. Keys you do not mention stay. One rollout carries the whole change.
  • A second apps env set while a rollout is already in progress still returns 409. That is the in-flight case, not two keys in one command.

Test plan

  • runware serverless apps env set my-app --env FOO=bar --env BAZ=qux stores both, and a following apps env list still shows the keys that were already set
  • apps env set my-app MY_KEY --value hello still sets one key
  • Mixing <key> --value with --env is rejected

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: da4e7718-8058-4fc9-89be-526441a558fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread internal/cmd/serverless/env.go
Comment thread internal/cmd/serverless/env_test.go Outdated
Comment thread internal/cmd/serverless/env.go Outdated
Comment thread internal/cmd/serverless/env.go Outdated
Comment thread internal/cmd/serverless/env.go Outdated
Comment thread internal/cmd/serverless/env.go
apps env set wrote one key per request, so a second set during that rollout returned 409 and stored nothing. --env and --env-file now merge into the current set and write it once.
An empty --value is a real assignment. The bulk write 409s only on a create or resume rollout, and keys you omit stay only when no other writer races the replace.
@Ryank90
Ryank90 force-pushed the feat/serverless-env-batch branch from 53c3def to 1c043ea Compare September 24, 2026 15:42
@Ryank90
Ryank90 merged commit ca595a5 into rc/serverless Sep 24, 2026
4 checks passed
@Ryank90
Ryank90 deleted the feat/serverless-env-batch branch September 24, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants