fix(serverless): set several environment variables in one rollout - #136
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
apps env set wrote one key per request, so a second set during that rollout returned 409 and stored nothing. --env and --env-file now merge into the current set and write it once.
An empty --value is a real assignment. The bulk write 409s only on a create or resume rollout, and keys you omit stay only when no other writer races the replace.
53c3def to
1c043ea
Compare
Summary
apps env setstill sets one key with<key> --valueor--value-file.--env KEY=VALUEand--env-fileread the current set, merge those keys, and write it in one request. Keys you do not mention stay. One rollout carries the whole change.apps env setwhile a rollout is already in progress still returns 409. That is the in-flight case, not two keys in one command.Test plan
runware serverless apps env set my-app --env FOO=bar --env BAZ=quxstores both, and a followingapps env liststill shows the keys that were already setapps env set my-app MY_KEY --value hellostill sets one key<key> --valuewith--envis rejected